use log10 to calculate the number of digits #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way it is not necessary to have a loop and should be a little bit more efficient.
|
Oooh, super cool! 🎉 |
|
Seems like we are waiting on rust-lang/rust#70887 to avoid the float conversion |
|
Ah good catch, added a comment on that. |
mbartlett21
pushed a commit
to mbartlett21/codespan
that referenced
this pull request
Oct 28, 2021
This way it is not necessary to have a loop and should be a little bit more efficient.
mbartlett21
pushed a commit
to mbartlett21/codespan
that referenced
this pull request
Oct 28, 2021
followup of brendanzab#332
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way it is not necessary to have a loop and should be a little bit more efficient.