8000 Change multiline rendering with breaks to work properly by mbartlett21 · Pull Request #330 · brendanzab/codespan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change multiline rendering with breaks to work properly #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2021
Merged

Change multiline rendering with breaks to work properly #330

merged 2 commits into from
Jul 8, 2021

Conversation

mbartlett21
Copy link
Contributor

I ran into this when trying to replicate the example showing what all the parts were

Example Before: 
error[0001]: oh noes, a cupcake has occurred!
   ┌─ test:4:1
   │
 4 │   ╭ Cupcake ipsum dolor. Sit amet marshmallow topping cheesecake
 5 │   │ muffin. Halvah croissant candy canes bonbon candy. Apple pie jelly
   │ ╭─│─────────'
   ·   │
10 │ │ │ Muffin danish chocolate soufflé pastry icing bonbon oat cake.
11 │ │ │ Powder cake jujubes oat cake. Lemon drops tootsie roll marshmallow
   │ │ ╰─────────────────────────────' blah blah
   · │ │
19 │ │   soufflé marzipan. Chocolate bar oat cake jujubes lollipop pastry
20 │ │   cupcake. Candy canes cupcake toffee gingerbread candy canes muffin
   │ ╰──────────' blah blah

After:

error[0001]: oh noes, a cupcake has occurred!
   ┌─ test:4:1
   │
 4 │   ╭ Cupcake ipsum dolor. Sit amet marshmallow topping cheesecake
 5 │   │ muffin. Halvah croissant candy canes bonbon candy. Apple pie jelly
   │ ╭─│─────────'
   · │ │
10 │ │ │ Muffin danish chocolate soufflé pastry icing bonbon oat cake.
11 │ │ │ Powder cake jujubes oat cake. Lemon drops tootsie roll marshmallow
   │ │ ╰─────────────────────────────' blah blah
   · │
19 │ │   soufflé marzipan. Chocolate bar oat cake jujubes lollipop pastry
20 │ │   cupcake. Candy canes cupcake toffee gingerbread candy canes muffin
   │ ╰──────────' blah blah

@Johann150 Johann150 merged commit 12dc87d into brendanzab:master Jul 8, 2021
@Johann150
Copy link
Contributor

Thanks for finding and fixing this!

@brendanzab
Copy link
Owner

Ditto!

@mbartlett21 mbartlett21 deleted the mb-edits branch July 9, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
4F9D
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbartlett21 @Johann150 @brendanzab
0