Syncing from upstream odoo/odoo (staging.16.0) #33761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the browser triggers a request just as a tour is finishing up (e.g. navigation to a new page triggering a font fetch), the harness can close the websocket con 8000 nection while the request is in the `requestPaused` proxy, causing the reply to fail and trigger an error. We can just ignore the error in that case. An alternative would be to enqueue a future into `_responses` when we receive the query, but that would still have a race as depending on scheduling decisions the browser could have already shut down by the time we reach the handler, so we'd need to enqueue a future, check if `ws` is still open, and bail if not. And even then that's still got a hole as there is some time between the `wait(_responses.values())` and the `ws.close()`. https://runbot.odoo.com/odoo/error/186309 closes #213911 Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Adding `country_id` to the newly introduced tax groups 4485693 closes #213917 Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>
When doing a Invoice B to exempts customer we have a problem: the RG Leyend new table is not showed, This because if the VAT Content and other taxes were 0. After checking with ARCA Online PDF report, and some feedback with customers we found out that the Leyend it is always shown and the VAT content line is always shown, even if VAT taxes are 0.0. Only need to hide the other taxes line if this one is 0.0 We also add a new key to the dictionary that prepare the tax detail values to properly identify the group of taxes. If not we will need to depend on the translations of the name to check which group it is. Update unit test to follow this new approach and also add a unit case where vat tax 0.0 and not other taxes are added. opw-4814730 closes #207367 Signed-off-by: Antoine Dupuis (andu) <andu@odoo.com>
Commit [1] added a compatibility layer when we switched to Bootstrap 4.
That compatibility layer actually still exists in master, even though
we are now using Bootstrap 5. A specific rule was forcing input-group
elements on one row... which conflicts with the fact that invalid
feedbacks are supposed to wrap on the next row.
This commit fixes that by re-enabling the wrap, when such a feedback is
displayed only. In master, the rule should probably be removed, hoping
outdated layouts were updated to Bootstrap 4+ correctly at this point
(not even sure what exactly is broken by not forcing the input-group on
one row).
Steps to reproduce:
- Add a form in your website page
- Add a date field (this is an input-group)
- Make it required
- Save
- Open the HTML editor(*) and add an invalid-feedback in that field
- Save
- Send your form without filling it => the input-group is broken
(*) starting from 18.4, there is a standard use case on the /my/security
page. There might be unknown usecases between 16.0 and 18.4.
[1]: 7aa473e
Related to task-3959739
closes #214029
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
### Contains the following commits: odoo/o-spreadsheet@fb0036b91 [REL] 16.0.72 [Task: 0](https://www.odoo.com/odoo/2328/tasks/0) odoo/o-spreadsheet@1de9db085 [IMP] demo: add clear action [](https://www.odoo.com/odoo/2328/tasks/) odoo/o-spreadsheet@6e680107b [FIX] filter: fix horrible performances with huge data filters [Task: 4658998](https://www.odoo.com/odoo/2328/tasks/4658998) odoo/o-spreadsheet@2d564135e [FIX] base_extractor: properly handle 0 as default value [Task: 4730308](https://www.odoo.com/odoo/2328/tasks/4730308) closes #213944 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com> Co-authored-by: Anthony Hendrickx (anhe) <anhe@odoo.com> Co-authored-by: Alexis Lacroix (laa) <laa@odoo.com> Co-authored-by: Lucas Lefèvre (lul) <lul@odoo.com> Co-authored-by: Dhrutik Patel (dhrp) <dhrp@odoo.com> Co-authored-by: Adrien Minne (adrm) <adrm@odoo.com> Co-authored-by: Mehdi Rachico (mera) <mera@odoo.com> Co-authored-by: Florian Damhaut (flda) <flda@odoo.com> Co-authored-by: Rémi Rahir (rar) <rar@odoo.com> Co-authored-by: Pierre Rousseau (pro) <pro@odoo.com> Co-authored-by: Vincent Schippefilt (vsc) <vsc@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot