8000 feat: format numbers using current locale by gselig1a · Pull Request #622 · boyter/scc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: format numbers using current locale #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

feat: format numbers using current locale #622

merged 1 commit into from
Jun 19, 2025
+200 −203

Conversation

gselig1a
Copy link
Contributor

Makes it more readable for short summary, just like for the "Estimated Cost to Develop" like:
10,000,000 instead of 10000000
fixes #335

Before

image

After

image

  • Markdown fixes

@gselig1a
feat: format numbers using current locale
f6200b1 
Makes it more readable for short summary:
10,000,000 instead of 10000000

fixes boyter#335
@boytertesting boytertesting bot added VL/complexity Very low complexity XL/size Extra large change labels Jun 19, 2025
gselig1a
gselig1a commented Jun 19, 2025
View reviewed changes
README.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot of small fixes to make Markdownlint happy.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of those things I have been kicking down the road forever. Thanks for actually fixing it.

gselig1a
gselig1a commented Jun 19, 2025
View reviewed changes
README.md
@@ -324,44 +322,48 @@ Flags:

Output should look something like the below for the redis project

```
```text
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated example with the new formatting

@boyter boyter merged commit b73ea06 into boyter:master Jun 19, 2025
4 checks passed
@boyter
Copy link
Owner
boyter commented Jun 19, 2025

Thanks for that @gselig1a ill ensure it makes the next release which should come right after the next version of Go is released.

@boyter
Copy link
Owner
boyter commented Jun 19, 2025 •
edited
Loading

Although I will need to tweak the output slightly

$ scc
───────────────────────────────────────────────────────────────────────────────
Language                 Files     Lines   Blanks  Comments     Code Complexity
───────────────────────────────────────────────────────────────────────────────
CSV                        341     9,030        0         0    9,030          0
Go                          56     6,688      909       297    5,482        797
XML                         49       695        0         0      695          0
Markdown                    11       571      182         0      389          0
W.I.S.E. Jobfile             8 9,455,824        0         0 9,455,824          0
SQL                          7       192       32        32      128          0
JSON                         5       100        0         0      100          0
Python                       5     2,944      342       138    2,464        649
Shell                        5        97       19        19       59          8
YAML                         5       183        8        13      162          0
Dockerfile                   4        55       14         1       40          5
Plain Text                   3       245        0         0      245          0
Makefile                     2       100       30         4       66         10
CSS                          1        33        5         0       28          0
HTML                         1        24        0         0       24          0
JavaScript                   1        42        5         0       37          1
TOML                         1     2,228       86         4    2,138          0
───────────────────────────────────────────────────────────────────────────────
Total                      505 9,479,051    1,632       508 9,476,911      1,470
───────────────────────────────────────────────────────────────────────────────
Estimated Cost to Develop (organic) $404,664,836
Estimated Schedule Effort (organic) 134.62 months
Estimated People Required (organic) 267.06
───────────────────────────────────────────────────────────────────────────────
Processed 301505453 bytes, 301.505 megabytes (SI)
───────────────────────────────────────────────────────────────────────────────

Need to reduce the word complexity as that count should always be smaller. I may replace it with Cplx which saves a lot of space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyter boyter boyter left review comments

Assignees
No one assigned
Labels
VL/complexity Very low complexity XL/size Extra large change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option for human-readable format
2 participants
@gselig1a @boyter
0