Automounts #613
Merged
Automounts #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#603
Purpose
bosh exec launchshould mount all the input files present in the invocation, unless automount is disabled with option--no-automounts.Current behaviour
User must manually mount files using
-v, --volumes.New behaviour
Inputs with property
type: Filewill be added to list of mount_stringsThis applies to list of files as well
Path must be absolute because relative paths are likely to break inside of container. Input value is used as both
srcanddsc(following docker's-v /src:/dsc).Implementation Detail
Added automounts so all input files in invocation are mounted to container.
Added
--no-automountsas an option to disable automounts of files./srcand/dscare taken from invocation and identical so we don't have to modify invocation values during execution.