8000 Bosh deprecate by DarrinFong · Pull Request #593 · boutiques/boutiques · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bosh deprecate #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 17, 2020
Merged

Bosh deprecate #593

merged 7 commits into from
Mar 17, 2020

Conversation

DarrinFong
Copy link
Contributor
@DarrinFong DarrinFong commented Mar 11, 2020

Related issues

#428 #402

Purpose

Allow original publisher of tool on Zenodo to deprecate it so newer versions (as separate record) can be published by a different user.

Current behaviour

No way to remove outdated zenodo tools from bosh search results.
No official way to link old version of tool to a newer tool (as separate record).

New behaviour

bosh deprecate [ZID1] --zenodo-token [ZTOKEN]
Optional: --by [ZID2]

Will add deprecate keyword to the newest version of the tool ZID1 and it will no longer appear in bosh search (can be made visible with --verbose search).

If argument --by [ZID2] is added, tool ZID1 will have an additional deprecated-by-doi:[ZID2] keyword. As well as a "New versions" related identifier pointing to tool ZID2.

Tool descriptor will contain field 'deprecated-by-doi': [True OR ZID2] depending on whether ZID2 is specified with --by flag.

Implementation Detail

Added deprecate function to bosh.py (should update Docs).
Checks existing deprecation and prompts with (Y/n) confirmation.
Uses publisher to update tool with new Keywords and Related identifier.
Added "deprecated-by-doi": {..."type": ["string", "boolean"]...} field to descriptor schema.
Searcher in verbose mode displays deprecated status as a new results column.

@DarrinFong DarrinFong changed the base branch from master to develop March 11, 2020 13:44
@coveralls
Copy link
coveralls commented Mar 11, 2020

Coverage Status

Coverage decreased (-0.005%) to 94.017% when pulling 9d6fb9c on DarrinFong:bdeprecate_#428 into cf5ec2e on boutiques:develop.

Copy link
Member
@glatard glatard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @DarrinFong!

@glatard glatard merged commit 47988e2 into boutiques:develop Mar 17, 2020
@glatard glatard mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0