Add Pre-Run script to launch options #3336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use bottle names md5 hash for directory creation
- use GtkFileDialog as native file chooser caused a segfault because the underlying GtkTask failed on assert GTK_IS_FILE_SYSTEM_MODEL (or similar) - added fields to the launch options dialog - added parameters to functions/methods down the execution path
Pylint result on modfied files: |
Tested with $ bottles-cli -b "Star Citizen" -p "Star Citizen"
|
Please review. I think I've catched all appeareances of 'script' and replaced them with pre_/post_script. For Star Citizen, I'm removing the EAC directory before launch and it's not complaining about Hub authentication any more. It is basically the only use case I have. Is there anything else left to do? Best regards. |
|
SonarQube Quality Gate |
|
Sorry I can check this only now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed (if available).
Please also include relevant motivation and context.
Fixes #2274
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
To test it I've set up a script to remove the EAC directory of my Star Citizen installation. Now that the directory gets cleared beforehand, it passes the hub-authentication without an error.
Take this as an initial draft that needs to be discussed/reviewed. There are several execution paths through bottles and I only tested one.
Also, the use of GtkFileDialog was not intended, but the native file chooser does not work on my system. The underlying GtkTask fails on an assertion which leads into a segfault.