8000 Use a single thread for download_fileobj for append mode by hssyoo · Pull Request #4503 · boto/boto3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use a single thread for download_fileobj for append mode #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bo 8000 ttom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Use a single thread for download_fileobj for append mode #4503

merged 1 commit into from
Apr 10, 2025
+58 −1

Conversation

hssyoo
Copy link
Contributor
@hssyoo hssyoo commented Apr 10, 2025

Fixes #1446 by using a single thread if the provided file-like object for download_fileobj is in append mode.

@hssyoo hssyoo requested a review from nateprewitt April 10, 2025 19:24
@hssyoo hssyoo merged commit 81e617e into boto:develop Apr 10, 2025
39 checks passed
@hssyoo hssyoo deleted the download-fileobj-append branch April 10, 2025 19:51
@hssyoo hssyoo mentioned this pull request Apr 11, 2025
Closed
@josemariane josemariane mentioned this pull request May 6, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateprewitt nateprewitt nateprewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

download_fileobj with a file object in append mode can mess up file content
2 participants
@hssyoo @nateprewitt
0