8000 expose GPSFactor in python wrapper, and add example for it by MandyXie · Pull Request #155 · borglab/gtsam · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

expose GPSFactor in python wrapper, and add example for it #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2019
Merged

expose GPSFactor in python wrapper, and add example for it #155

merged 1 commit into from
Oct 21, 2019

Conversation

MandyXie
Copy link
@MandyXie MandyXie commented Oct 20, 2019 •
edited by dellaert
Loading

This change is Reviewable

@MandyXie MandyXie requested a review from dellaert October 20, 2019 01:41
@dellaert
Copy link
Member

Hi @MandyXie ! Thanks for doing this. I thought the reporters of the issue were hoping to do a PR, but this works :-) The PR itself looks good to me but the Travis build failed for clang. I restarted both branch and PR builds, we’ll see.

Does the wrapper build and the example run in python for you? Travis does not check that...

@MandyXie
Copy link
Author

Hi @MandyXie ! Thanks for doing this. I thought the reporters of the issue were hoping to do a PR, but this works :-) The PR itself looks good to me but the Travis build failed for clang. I restarted both branch and PR builds, we’ll see.

Does the wrapper build and the example run in python for you? Travis does not check that...

Yes, it works.

dellaert
dellaert approved these changes Oct 20, 2019
View reviewed changes
Copy link
Member
@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I restarted part of build that was canceled, after that we’ll be able to merge.

@dellaert dellaert merged commit 0f790e8 into develop Oct 21, 2019
@dellaert dellaert deleted the feature/exposeGPSFactor branch October 21, 2019 06:20
@dellaert dellaert mentioned this pull request Oct 21, 2019
Closed
varunagrawal added a commit that referenced this pull request Oct 28, 2022
@varunagrawal
Squashed 'wrap/' changes from b37a1fec6..b3faf3fcd
e5dac42 
b3faf3fcd Merge pull request #155 from borglab/fix/matlab-properties
292b35440 fix python test
53053173e fix properties block bug in Matlab and add test to capture it

git-subtree-dir: wrap
git-subtree-split: b3faf3fcd1e805828decf67fc32814f104c3c1c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MandyXie @dellaert
0