8000 dot argument order by dellaert · Pull Request #989 · borglab/gtsam · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

dot argument order #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 26, 2021
Merged

dot argument order #989

merged 3 commits into from
Dec 26, 2021

Conversation

dellaert
Copy link
Member

Sorry for the churn, but I screwed up argument order in factor graph dot methods.
I switched formatter and writer arguments to be more inline with BayesNet etc.

@dellaert dellaert requested a review from ProfFan December 25, 2021 18:52
varunagrawal
varunagrawal approved these changes Dec 25, 2021
View reviewed changes
Copy link
Collaborator
@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dellaert dellaert merged commit 4d64cb5 into develop Dec 26, 2021
@dellaert dellaert deleted the fix/dot_arguments branch December 26, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

@ProfFan ProfFan Awaiting requested review from ProfFan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dellaert @varunagrawal
0