Cython wrapper for all release modes #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Took off Mandy and Jose as reviewers, suggest you add Duy and Matthew |
dellaert
reviewed
Jun 12, 2019
|
Adding @jlblancoc again because maybe you should be merging this into his PR, not straight into develop? Lots of cmake changes there... I'll let him comment: if the two PR's are not conflicting, you can just target develop as is. |
|
I can rebase off the branch once it is approved/merged and make the needed changes, if that works? |
d3abb3e to
9d92108
Compare
|
Resolve conflicts so we can merge? |
- Added top-level cmake build type upper case variable. - Added new GTSAM_BUILD_TAG variable for use in wrapping gtsam_eigency. - Removed FATAL message regarding GTSAM_BUILD_TYPE_POSTFIXES.
- Update install directory so that the release tag is appended to the cython directory only rather than the specific subdirectories. - Update the target properties so that the .so files don't have the build type appended as a postfix.
9d92108 to
37aa167
Compare
|
Rebase done. It was pretty quick. 😄 |
|
Ok let’s wait for travis |
varunagrawal
added a commit
that referenced
this pull request
Mar 26, 2021
96ccdfd0b Merge pull request #65 from borglab/fix/special-cases 04c06b7e6 Merge pull request #63 from borglab/fix/cmake bf2c91bd2 fix issue in template instantiation generator 152dbcb12 test for special cases d03004b24 fixed the cmake to discover the correct python version and set all corresponding variables 4cf66e0da Merge pull request #61 from borglab/fix/python-variables 80558e35b added more status messages and set the PYBIND11_PYTHON_VERSION each time 73afd1b0a set both sets of Python variables and find python version when including PybindWrap REVERT: 9a467794e Merge pull request #61 from borglab/fix/python-variables REVERT: 6bae7af99 added more status messages and set the PYBIND11_PYTHON_VERSION each time REVERT: 5129cf3b9 set both sets of Python variables and find python version when including PybindWrap git-subtree-dir: wrap git-subtree-split: 96ccdfd0b84a4dbf1b3e9ed31b95ebc2758be9cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upates the CMake files so that the generated cython wrapper only appends the build type postfix to the top-level
cythondirectory in the install path, rather than appending it to the sub-directories or.sofiles since that would cause import issues when using the cython wrapper in any mode other thanRelease.This was a doozy, but it works and should be a huge step forward with respect to improvements in the python wrapper.
This change is