Make cache_dir a required param when initializing LiveFileSourceSSH #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cache_dir=None` seems to imply that `cache_dir` can be omitted, or that the default value of `None` will mean no cache dir is used. But actually the class fails to initialize because line 185 expects `cache_dir` to be non-null. This change requires `cache_dir` to be specified so that the class does not fail to initialize during runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cache_dir=Noneseems to imply thatcache_dircan be omitted, or that the default value ofNonewill mean no cache dir is used.But actually the class fails to initialize because line 185 expects
cache_dirto be non-null.This change requires
cache_dirto be specified so that the class does not fail to initialize during runtime.