Move inline styles to CSS #40
Conversation
The background image config was an inline style. This change migrates the style into a stylesheet in a backward-compatible way, which would make it easier to override in custom CSS. Signed-off-by: Brian Warner <brian@bdwarner.com>
|
Thanks, that makes sense. Just repeating it back to make sure I'm getting it, my understanding is that In that case, could this be accomplished by using a relative URL in the stylesheet? I'm making assumptions that 1) the welcome page will always be at the root of the Hugo site, and 2) the welcome page is the only one to use this directive. If that's the case, whether at top level or nested, What do you think? |
|
Hmm, seems you're correct. It's only used at the welcome page, but I need to check to be sure, I plan to check it this weekend. |
The background image, by default, is one directory higher than the stylesheets. Using a relative path will enable both root-level and subdirectory installations. Signed-off-by: Brian Warner <brian@bdwarner.com>
|
It's a very small patch, but I just pushed it so you can try it directly from this branch. |
Another minor contribution to increase the flexibility of the theme. The background image config was an inline style. This change migrates the style into a stylesheet in a backward-compatible way, which would make it easier to override in custom CSS.