8000 fix(build): Compile time recursion limit back to default by timonv · Pull Request #379 · bosun-ai/kwaak · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(build): Compile time recursion limit back to default #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

timonv
Copy link
Member
@timonv timonv commented Mar 3, 2025

Previously this was configured to have tracing play nice with lancedb. Doesn't seem to be necessary anymore.

I'm not sure if it's just a limit or also affects optimizations. Either way doesn't hurt to remove.

@timonv timonv merged commit 88c5d97 into master Mar 3, 2025
12 checks passed
@timonv timonv deleted the fix/default-recursion-limit branch March 3, 2025 10:57
timonv added a commit that referenced this pull request Mar 3, 2025
Previously this was configured to have tracing play nice with lancedb.
Doesn't seem to be necessary anymore.

I'm not sure if it's just a limit or also affects optimizations. Either
way doesn't hurt to remove.
timonv pushed a commit that referenced this pull request Mar 5, 2025
## 🤖 New release

* `kwaak`: 0.13.0 -> 0.14.0 (⚠ API breaking changes)

### ⚠ `kwaak` breaking changes

```text
--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field Chat.repository in /tmp/.tmpqnxoOD/kwaak/src/chat.rs:28
  field App.update_available in /tmp/.tmpqnxoOD/kwaak/src/frontend/app.rs:96

--- failure enum_tuple_variant_changed_kind: An enum tuple variant changed kind ---

Description:
A public enum's exhaustive tuple variant has changed to a different kind of enum variant, breaking possible instantiations and patterns.
        ref: https://doc.rust-lang.org/reference/items/enumerations.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_tuple_variant_changed_kind.ron

Failed in:
  variant CommandResponse::Completed in /tmp/.tmpqnxoOD/kwaak/src/commands/responder.rs:21

--- failure enum_tuple_variant_field_missing: pub enum tuple variant's field removed ---

Description:
A field of a tuple variant in a pub enum has been removed.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_tuple_variant_field_missing.ron

Failed in:
  field 1 of variant CommandResponse::Chat, previously in file /tmp/.tmpiOBn2X/kwaak/src/commands/responder.rs:17
  field 1 of variant CommandResponse::Activity, previously in file /tmp/.tmpiOBn2X/kwaak/src/commands/responder.rs:19
  field 1 of variant CommandResponse::RenameChat, previously in file /tmp/.tmpiOBn2X/kwaak/src/commands/responder.rs:21
  field 1 of variant CommandResponse::RenameBranch, previously in file /tmp/.tm
7DAE
piOBn2X/kwaak/src/commands/responder.rs:23
  field 1 of variant CommandResponse::BackendMessage, previously in file /tmp/.tmpiOBn2X/kwaak/src/commands/responder.rs:25

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_variant_added.ron

Failed in:
  variant UserInputCommand:Github in /tmp/.tmpqnxoOD/kwaak/src/frontend/ui_input_command.rs:58
  variant UIEvent:GithubFixIssue in /tmp/.tmpqnxoOD/kwaak/src/frontend/ui_event.rs:53

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/inherent_method_missing.ron

Failed in:
  CommandResponse::with_uuid, previously in file /tmp/.tmpiOBn2X/kwaak/src/commands/responder.rs:32

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/method_parameter_count_changed.ron

Failed in:
  kwaak::frontend::UserInputCommand::to_ui_event now takes 2 parameters instead of 1, in /tmp/.tmpqnxoOD/kwaak/src/frontend/ui_input_command.rs:122

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/struct_missing.ron

Failed in:
  struct kwaak::config::DisabledTools, previously in file /tmp/.tmpiOBn2X/kwaak/src/config/config.rs:151

--- failure struct_pub_field_missing: pub struct's pub field removed or renamed ---

Description:
A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/struct_pub_field_missing.ron

Failed in:
  field disabled_tools of struct Config, previously in file /tmp/.tmpiOBn2X/kwaak/src/config/config.rs:86
```

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.14.0] - 2025-03-05

### 🚀 Features

- Faster docker builds with buildkit
- Check for updates on boot with a more compact header (#380)
- Reinject original prompt in summarizer (#374)
- [**breaking**] Opt-out of any tool (#378)
- Support storing `kwaak.toml` in `.config/kwaak.toml` (#384)
- [**breaking**] Rework tool configuration to support Opt-in as well
(#387)
- Fix github issues with `/github fix <issue>` and enjoy the show (#373)

### 🐛 Bug Fixes

- *(build)* Compile time recursion limit back to default (#379)
- Quick test tools in the docker executor (#372)
- Do not wait for splash if done indexing
- Flaky test should account for ordering

### 💼 Other

- Optimize docker build time (#370)

### 🚜 Refactor

- Remove Uuid from command responses and implement default members
(#386)

<!-- generated by git-cliff -->
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0