fix(tracing): Run otel in http mode if enabled #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many hosted parties (openobserve, grafana, etc) do not support pure grpc
tinco
approved these changes
Jan 24, 2025
This was referenced Jan 24, 2025
Closed
Closed
Merged
timonv
pushed a commit
that referenced
this pull request
Jan 24, 2025
## 🤖 New release * `kwaak`: 0.5.0 -> 0.6.0 (⚠️ API breaking changes) ###⚠️ `kwaak` breaking changes ``` --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/constructible_struct_adds_field.ron Failed in: field App.input_width in /tmp/.tmpGvtH5P/kwaak/src/frontend/app.rs:85 --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.38.0/src/lints/function_parameter_count_changed.ron Failed in: kwaak::git::util::diff now takes 3 parameters instead of 2, in /tmp/.tmpGvtH5P/kwaak/src/git/util.rs:9 ``` <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.6.0] - 2025-01-24 ### 🚀 Features - Add ctrl+enter and shift+enter as shortcuts to send a message (#219) - Adjust arrow key behavior in chat input (#220) - Wrap input lines neatly when chatting with an agent (#226) - Enable overwriting config with env variables or a kwaak.local.toml (#222) - Use the git diff to steer on test and coverage results (#229) ### 🐛 Bug Fixes - *(ci)* Remove rust cache - *(tracing)* Run otel in http mode if enabled (#218) - Local docker executor now returns NonZeroExit correctly on file not found - *(tools)* Allow for block edit to also insert new lines (#227) - Disable ultra verbose ui event logging on debug ### ⚙️ Miscellaneous Tasks - Add persistance to jaeger in compose - Ensure the are no dangling trace spans <!-- generated by git-cliff --> </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many hosted parties (openobserve, grafana, etc) do not support pure grpc