fix: ignore cgo files #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39827b7 to
4061863
Compare
2629974 to
6bab1f5
Compare
bombsimon
reviewed
Apr 2, 2025
Comment on lines
+91
to
+94
| // if the file is related to cgo the filename of the unadjusted position is a not a '.go' file. | ||
| if !strings.HasSuffix(fn, ".go") { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Maybe we can just return pass.Fset.PositionFor(file.Pos(), false).Filename from getFilename, or even drop getFilename and just do this once? I don't think there's any need for first calling getFilename to get potential adjusted position/file and then again here to skip it.
There was a problem hiding this comment.
if we do that, the line directive will not work.
There was a problem hiding this comment.
For files with line directives:
- adj: The filename is not a Go file
- non-adj: The filename is a Go file
For files with cgo:
- adj: The filename is a Go file
- non-adj: The filename is not a Go file (but its' a Go file 😉)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #159, #157
the cgo support is dropped, but the tests are kept to avoid regression.
Fixes #162