Explicitly use std::move #349
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason for using See what is being imported/set before/after C++11: https://github.com/bombela/backward-cpp/blob/master/backward.hpp#L414 |
|
However, the build system requires C++11: https://github.com/bombela/backward-cpp/blob/master/CMakeLists.txt#L65 |
|
You do not have to use CMake. In fact I personally do not really maintain
the CMake part. I barely know how it works to tell the truth. I leave it to
contributors.
The "build system" used to test backward-cpp is merely a shell script.
Nothing more.
All you need is the .hpp, set the defines used to configure which unwind
and symbol resolution library you want to use. And then do not forget to
link appropriately to the libraries you have chosen. And the documentation
and list of libraries is found at the top of the .hpp.
The .hpp must compile on C++98 and onward. I recommend using backward-cpp
by simply copying the .hpp and adding whatever rule is necessary to your
build system.
Of course any contribution to the CMake configuration is welcome too :)
…On Tue, Apr 15, 2025, 13:57 Jakub Klinkovský ***@***.***> wrote:
However, the build system requires C++11:
https://github.com/bombela/backward-cpp/blob/master/CMakeLists.txt#L65
—
Reply to this email directly, view it on GitHub
<#349 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUZDCNXSHWJLVUFT3FG632ZVXCJAVCNFSM6AAAAABY2C3BUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBXGQ4DMOJRGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
*lahwaacz* left a comment (bombela/backward-cpp#349)
<#349 (comment)>
However, the build system requires C++11:
https://github.com/bombela/backward-cpp/blob/master/CMakeLists.txt#L65
—
Reply to this email directly, view it on GitHub
<#349 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUZDCNXSHWJLVUFT3FG632ZVXCJAVCNFSM6AAAAABY2C3BUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBXGQ4DMOJRGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this library in a project that makes heavy use of linters/clang format etc and not using qualified std::move was causing compilation errors specifically in clang.
I made this change to accommodate for that