This repository was archived by the owner on Jan 1, 2021. It is now read-only.
Generate certs #477
Merged
Generate certs #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -120,6 +120,10 @@ RUN curl -L -o $ROOTFS/usr/local/bin/docker https://get.docker.io/builds/Linux/x | |||
| chmod +x $ROOTFS/usr/local/bin/docker && \ | |||
| { $ROOTFS/usr/local/bin/docker version || true; } | |||
|
|
|||
| # get generate_cert | |||
| RUN curl -L -o $ROOTFS/usr/local/bin/generate_cert https://github.com/SvenDowideit/generate_cert/releases/download/0.1/generate_cert-0.1-linux-386/ && \ | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Seems about as sane as it could be, for what it has to be. Couldn't we technically look to generate the certs in boot2docker-cli directly and push them into the VM the way we do the SSH keys instead of trying to pull them back out after they're generated? (possibly as a future enhancement) |
|
I did it this way so that the certs are also generated when using the iso without the boot2docker-cli, like the physical HW I use, or non-vbox setups. Also, At some point in the future Docker will probably do it. |
|
Makes sense; LGTM |
cpuguy83
pushed a commit
to cpuguy83/boot2docker
that referenced
this pull request
Aug 26, 2014
Generate certs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR contains #463
please only review the last commit.