Gateway: Patch Fix & Need Changes #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boyuan-chen
approved these changes
May 1, 2024
…ead of calculating again!
…oove button instead of 1hr delay!
There was a problem hiding this comment.
lgtm!
would value @wsdt's review more here
are we going to have the integ tests back running in this PR?
boyuan-chen
approved these changes
May 2, 2024
wsdt
approved these changes
May 2, 2024
|
@souradeep-das, As this changes has been already approved and to keep the pr with min change so going to merge and just to let you know I am getting integration back on different branch on local will rebase with main! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 closes:
Support for legacy weth support for old transactions on classic withdrawal!
Changes: