Merge upstream 20240813 #231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reum-optimism#10946) Bumps [curve25519-dalek](https://github.com/dalek-cryptography/curve25519-dalek) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/dalek-cryptography/curve25519-dalek/releases) - [Commits](dalek-cryptography/curve25519-dalek@curve25519-4.1.2...curve25519-4.1.3) --- updated-dependencies: - dependency-name: curve25519-dalek dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Drippie monitoring is now handled in monitorism.
…sm#10952) * ctb: Add safe extension contract auth to Specs.t.sol * ctb: Fix capitalization on Safe dir
…um-optimism#10823) * op-conductor: Add optional version parameter to cluster membership changes * Fix tests * Add API backwards compatibility for conductor changes * Clean up some boilerplate
…um-optimism#10943) * cannon: Extract handleHiLo, handleJump, handlRd from mips.go * cannon: Extract handleHiLo, handleJump, handlRd from MIPS.sol * cannon: Increment MIPS.sol version * cannon: Run semver-lock and snapshots * cannon: Fix slither warning - init variable to zero
* Fix OP-GETH broken link * use correct link * fix link
…imism#10967) * Use common.Hash type in asterisc VMState * Update asterisc test state
…#10971) * op-program: refactor to use events derivers * op-node: differentiate between invalid payload and invalid payload attributes
…e. (ethereum-optimism#10982) Current fault dispute rules are that the safe head is extended to the end of the trace.
* op-node: event handling on block attributes todo * op-node: update plasma step to no longer hardcode pipeline stepping
The `pnpm-workspace.yaml` file should no longer include a reference to the ts package that was removed along with the `indexer`.
Move the ts config out of the root of the repo to the packages themselves. This is because no new typescript development is planned for the monorepo itself, new typescript lives in the ecosystem monorepo, see https://github.com/ethereum-optimism/ecosystem. It may also live in the monitoring monorepo, see https://github.com/ethereum-optimism/monitorism. This will make porting the individual ts packages out of the monorepo more simple and also cleans up the root of the monorepo, reducing the overhead for contributors.
…enarios (ethereum-optimism#10976) * op-conductor: add override to disable HA mode in disaster recovery scenarios * op-conductor: add leader override in conductor API * Change leaderOverride to atomic.Bool
* op-supervisor: Introduce thread-unsafe log database * op-supervisor: Add simple r/w locking * op-supervisor: Add comment * op-supervisor: Start switching to multi-entry database format * op-supervisor: Improve test to cover the case where a new block starts at a search checkpoint boundary (other than at the start of the file) * op-supervisor: Use a flag to indicate when log index should increment rather than a 1 byte increment amount. * op-supervisor: Comment out unused stuff to make lint happy. * op-supervisor: Load correct block number and log idx on init * op-supervisor: Refactor state to only hold context that can always be kept up to date. * op-supervisor: Support rewinding * op-supervisor: Remove TODO that probably won't be done there * op-supervisor: Require first log in block to have logIdx 0 * op-supervisor: Remove completed TODO. * op-supervisor: Improve testing for logs not existing * op-supervisor: Fix typo * op-supervisor: Tidy up TODOs and pending tests. * op-supervisor: Add invariant assertions for db data * op-supervisor: Lock db in ClosestBlockInfo * op-supervisor: Label alerts * op-supervisor: Use a TruncatedHash for logs everywhere and make it a fixed size array. * op-supervisor: Separate serialization of initating events * op-supervisor: Separate serialization of other event types and enforce type code. * op-supervisor: Introduce entry type * op-supervisor: Split out an entry database * op-supervisor: Introduce structs for entry types * op-supervisor: Use a struct for CanonicalHash too
Implement checks for required fields in config and add tests for them.
…sm#10980) Bumps [github.com/minio/minio-go/v7](https://github.com/minio/minio-go) from 7.0.71 to 7.0.72. - [Release notes](https://github.com/minio/minio-go/releases) - [Commits](minio/minio-go@v7.0.71...v7.0.72) --- updated-dependencies: - dependency-name: github.com/minio/minio-go/v7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* op-chain-ops: cleanup foundry package Moves the foundry related code into the foundry package. We have some code for reading the allocs that foundry writes to disk with `vm.dumpState(string)`. It makes more sense to have these functions and types in the `foundry` package rather than the `genesis` package. * op-chain-ops: fix compile issue * op-node: port package usage
…um-optimism#10973) * op-supervisor: Support recording executing message info * op-supervisor: Reduce permissions * op-supervisor: Implement recovery for entry db * op-supervisor: Track size in entrydb instead of last entry idx * op-supervisor: Trim log entries back to the last valid ending point * op-supervisor: Remove the manual recover operations since recovery at startup is automatic * op-supervisor: Add support for writing multiple entries in a single write * op-supervisor: Write all entries for a log in one append call. Only update in-memory state after the write succeeds. * op-supervisor: Handle partial writes * op-supervisor: Extract logic to reverse an init event * op-supervisor: Use errors.New * op-supervisor: Combine the two AddLog variants. * op-supervisor: Remove place holder tests. * op-supervisor: Separate Executes and Contains queries * op-supervisor: Only read executing message when it is actually used.
Migrate to just from pnpm. This is continued tech debt cleanup away from `pnpm` and typescript that is no longer used.
…reum-optimism#11399) * Fix devnet-up when op-program/bin is missing prestate-proof.json * Fix cannon-prestate to always run * Add prestate.json
* ci: update geth tool to v1.14.7 * ci: temporarily disable L1 geth version check, so L1 geth can be updated * ops-bedrock: explicit hash state.scheme on geth
* Add RV reviews * Fix naming of trust audit to match convention
* chore: update to support geth v1.14.7 * Update geth * Fix "private key curve is not secp256k1" error * Temporarily quiet noisy logs * signature test * Add comments about S256 curve override fix * Update geth * go.mod: update to op-geth v1.101407.0-rc.1 * op-e2e: fix L1/L2 miner settings * Also update devnet L1 base image * ci: bump ci-builder in circleci --------- Co-authored-by: Danyal Prout <me@dany.al> Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Sebastian Stammler <seb@oplabs.co>
…timism#11426) * add additional address to exclude * chore: make public library methods internal * remove another public lib method * remove additional public lib methods * remove hardcoded assumption now that we know it's lib linking * style: forge fmt
* ci: manage versions in versions.json and optimize archive downloads to directly extract * ci: also pin just version
…ereum-optimism#11411) * cannon: Add support for --type mt to enable multithreaded cannon * cannon: Rename vm type to cannon-mt
…hereum-optimism#11373) * dependabot(gomod): bump golang.org/x/crypto from 0.25.0 to 0.26.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.25.0 to 0.26.0. - [Commits](golang/crypto@v0.25.0...v0.26.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * deps: update --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
…ereum-optimism#11369) * Rebase: op-supervisor: Include executing message info when storing logs. Takes from aj/parse-exec-msg and makes the following updates: - uses upstream ABI definitions for identifier hash - removes the core recording functionality for the moment - fixes up inconsistent typing and merge conflicts due to rearranged packages * Incorporate new ABI format * remove trailing newline in contract --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co>
Not necessary as it's checked further up the call tree. Without this --log.color doesn't work when intended.
…ism#11434) Scripts within contracts-bedrock are all over the place. Relatively minor PR that moves things around into a cleaner folder structure. Scripts themselves are unchanged.
…m-optimism#11443) * op-geth: update to support new precompile-overrides function * op-program: ensure no accidental precompile overrides * go.mod: update op-geth for new precompile override functionality
ethereum-optimism#11450) Bumps [github.com/urfave/cli/v2](https://github.com/urfave/cli) from 2.27.3 to 2.27.4. - [Release notes](https://github.com/urfave/cli/releases) - [Changelog](https://github.com/urfave/cli/blob/main/docs/CHANGELOG.md) - [Commits](urfave/cli@v2.27.3...v2.27.4) --- updated-dependencies: - dependency-name: github.com/urfave/cli/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-optimism#11448) Bumps ethereum/client-go from v1.14.7 to v1.14.8. --- updated-dependencies: - dependency-name: ethereum/client-go dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: introduce OptimismSuperchainERC20 * fix: contract fixes * feat: add snapshots and semver * test: add supports interface tests * test: add invariant test * feat: add parameters to the RelayERC20 event * fix: typo * fix: from param description * fix: event signature and interface pragma * feat: add initializer * feat: use unstructured storage and OZ v5 * feat: update superchain erc20 interfaces * fix: adapt storage to ERC7201 * test: add initializable OZ v5 test * fix: invariant docs * fix: ERC165 implementation * test: improve superc20 invariant (#11) * fix: gas snapshot --------- Co-authored-by: 0xng <ng@defi.sucks> Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
* Fix data races around p2p records Fixes ethereum-optimism#11328 * Remove some constructor boilerplate * Add data race fixes for op-node/p2p tests * Include book locking for record deletion * Add missing read locks * Move locks into wrappers * Remove ping service trace parameter from public API * I came in search of data races and I found refactors
…ism#11437) * op-challenger: Fix run-trace disputed block selection Previously it assumed the safe head at SafeL1 was before the safe head at HeadL1 in the sync status, but that is not guaranteed. As a result it could select an L2 block to check that was unsafe at the specified L1 head. * op-challenger: Update vm-runner to handle the case where op-node hasn't processed all finalized L1 blocks yet
) * contracts-bedrock: migrate interop portal to fp Utilize fault proofs in the interop portal. This is useful for removing the `L2OutputOracle` from the codebase. We will need to deploy the interop devnet using the permissioned dispute game after this change, so we want to ensure that the deploy script can set that up easily. * ctb: migrate interop to fp portal * snapshots: regenerate * lint: fix * contracts-bedrock: always enable fault proofs with interop * interop: support fault proofs * deploy script: only deploy correct contracts * contracts-bedrock: cleanup deploy * contracts-bedrock: fix deploy The deploy script is very coupled to unit tests * portal2: reduce codesize * lint: fix * snapshots: update * snapshots: update * semver-lock: regenerate * deploy script: update * tests: update excludes * summary: update
…ethereum-optimism#11457) * Add detail to the documentation to clarify any confusion. * fix format
boyuan-chen
pushed a commit
that referenced
this pull request
Sep 16, 2024
* Prevent reiniting preimage uploads. (#190) * fix(ctb): Perform correct clock validation in FDG constructor Fixes the clock extension / max clock duration check in the `FaultDisputeGame` constructor to account for the worst-case clock extension. * fix: add semver-lock * fix: add kontrol * gas snapshot * fix: gas snapshot and semver-lock --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co> Co-authored-by: refcell <abigger87@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Add associated issues, tickets, docs URL here.
Overview
Describe what your Pull Request is about in a few sentences.
Changes
Describe your changes and implementation choices. More details make PRs easier to review.
Testing
Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.