8000 fix: Use utf-8 encoding when saving config.toml file by quanticism · Pull Request #33 · blueaxis/Poricom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Use utf-8 encoding when saving config.toml file #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2023
Merged

fix: Use utf-8 encoding when saving config.toml file #33

merged 1 commit into from
Jan 28, 2023

Conversation

quanticism
Copy link
@quanticism quanticism commented Jan 23, 2023 •
edited by blueaxis
Loading

Closes #28

When opening a directory with Japanese characters and closing the app, the config.toml file was being saved with shift-jis encoding instead of utf-8, causing the program to crash when it tries to reread the config file.

@blueaxis blueaxis self-requested a review January 23, 2023 16:18
@blueaxis blueaxis mentioned this pull request Jan 28, 2023
Closed
@blueaxis blueaxis merged commit 2f6bcfc into blueaxis:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueaxis blueaxis blueaxis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError after opening a manga directory with UTF-8 characters
2 participants
@quanticism @blueaxis
0