Add file.DirectoryHash, file.FileHash and file.MoveDirectory #87
Conversation
|
Reference: See issue #85 |
src/lapi.cc
Outdated
| if(strlen(to) != toLen) | ||
| luaL_error(state, "file.MoveDirectory(from, to): argument 'to' cannot contain null characters!"); | ||
|
|
||
| bool result = rename(from, to) == 0; |
There was a problem hiding this comment.
would prefer (rename() == 0) fwiw.
lgtm tho
|
Have not compared side/side with BLT4W but everything looks good WRT style, with a few minor notes, primarily that I like newlines before any bracket, but I don't really care all that much. |
| #include <stack> | ||
| #include <algorithm> | ||
|
|
||
| #include <openssl/sha.h> |
There was a problem hiding this comment.
i suppose this resolves the long-time issue of OpenSSL vs GNUTLS WRT cURL deps on certain distros.
There was a problem hiding this comment.
Ideally, I'd use IFDEF to use either, but I've never used GNUTLS before.
There was a problem hiding this comment.
I personally don't care. There's always the option of implementing sha256 🎉.
But, you know, that's not really worthwhile.
src/lapi.cc
Outdated
|
|
||
| bool result = (rename(from, to) == 0); | ||
| lua_pushboolean(state, result); | ||
| if(!result) { |
There was a problem hiding this comment.
See my PR comment about brackets
There was a problem hiding this comment.
Yeah, I realized near the start that they should go on a seperate line, and changed them, but I must have missed a few. I'll fix that now too.
There was a problem hiding this comment.
How do you format catch(...) blocks?
|
@ZNixian lmk when you are ready for a merge |
src/lapi.cc
Outdated
| @@ -174,7 +177,8 @@ namespace blt { | |||
|
|
|||
| lua_pushlstring(state, hash.c_str(), hash.length()); | |||
| return 1; | |||
| } catch(string e) { | |||
| } | |||
| catch(string e) { | |||
There was a problem hiding this comment.
Still a hanging bracket there.
The accuracy of these functions has been tested using sha256sum and reading the source code of the windows version, so all results should match.