8000 Update README with Installation and Table Of Contents by ficcdaf · Pull Request #68 · blopker/codebook · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update README with Installation and Table Of Contents #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

ficcdaf
Copy link
Contributor
@ficcdaf ficcdaf commented Apr 19, 2025

I recently discovered this project and really like it, but I was frustrated by the lack of easy installation instructions, so I created an Arch User Repository package for Codebook's binary release. In adding it to the README, I also included more precise instructions for installing from the release manually, as well as using eget. Finally, I added a table of contents under a dropdown to the top of the document because there are a lot of sections and it's easy to get lost.

Once the cargo installation method discussed in #61 is implemented, it could be added to this section and noted as the "preferred" way to install the package. Finally, if you think this makes the README too crammed/busy, we could wrap the installation instructions in another <details> dropdown. Please let me know what you think.

@blopker
Copy link
Owner
blopker commented Apr 19, 2025

Thank you for this! Admittedly, I'm not experienced with the different packaging options out there. I mostly use brew myself.

After reading through the changes, I see that make build is what people expect to run, so I've updated it to not require bun (the compiled wordlist is checked in any way) and it now creates the release build instead of dev. That being said, downloading from the Releases page hopefully will be good enough for most people (where other installation methods are not sufficient).

Other notes:

For the ToC, I guess a lot of people don't know this, but GitHub has it built in:
Screenshot 2025-04-19 at 9 53 31 AM min

I'd rather not have to maintain it manually as the README changes.

Also, I've found that almost nothing we (programmers) do is easy. I tend to not use words like easily (or just) in documentation because it can make people unnecessarily frustrated if it's not.

@blopker
Copy link
Owner
blopker commented Apr 19, 2025

Also, I've never published a crate before. Any help you might have with that would be huge!

@ficcdaf
Copy link
Contributor Author
ficcdaf commented Apr 19, 2025

Also, I've found that almost nothing we (programmers) do is easy. I tend to not use words like easily (or just) in documentation because it can make people unnecessarily frustrated if it's not.

You make a good point, I'll adjust that wording and remove the TOC section in that case.

I still think listing package options is a good idea. Speaking for myself, I always prefer to install something via a package manager, and manually installing a GitHub release is the last resort. Of course, packaging for every conceivable platform is not feasible. I personally use pacman on Arch for nearly everything, so when something I want to use isn't available, I create an AUR package for it -- I already maintain a couple of these.

Basically, I think it doesn't hurt to list the AUR, since it already exists, and the eget method is basically a more convenient way of installing and updating binaries from GitHub releases. It could be worth it to figure out packaging for brew as well.

Also, I've never published a crate before. Any help you might have with that would be huge!

I'm not a Rust programmer so neither have I 😉 but it would definitely be important to figure out, since I think cargo is one of the best ways to distribute a package cross-platform.

@blopker
Copy link
Owner
blopker commented Apr 19, 2025

Great! I didn't mean to say that the different packaging options should not be listed, sorry for the confusion. I get that everyone and every platform has their preferred solution.

We definitely need a section on that!

@ficcdaf
Copy link
Contributor Author
ficcdaf commented Apr 21, 2025

Removed the TOC and removed the "easily install" wording

@blopker
Copy link
Owner
blopker commented Apr 22, 2025

Looks great! Thanks again.

@blopker blopker merged commit c900f46 into blopker:main Apr 22, 2025
@ficcdaf ficcdaf deleted the update-readme branch April 23, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0