8000 Improved the structure and flow of the project creation wizard by miladsoft · Pull Request #407 · block-core/angor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improved the structure and flow of the project creation wizard #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 15, 2025

Conversation

miladsoft
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings May 31, 2025 12:23
Copilot

This comment was marked as outdated.


@if (!hasErrors && !isManualMode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this isManualMode and AutomaticMode?
If there was an error it goes to manual mode?

@dangershony
Copy link
Member

I see you kept the auto/manual mode but I don't think we need that

@miladsoft miladsoft requested a review from Copilot June 11, 2025 12:57
Copy link
8000
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces two new utility classes to support fixed sizing within the project creation wizard’s layout.

  • Adds a .width-40 class for setting element width to 40px
  • Adds a .height-40 class for setting element height to 40px

<div class="text-center mb-4">
<div class="alert alert-danger d-flex align-items-center justify-content-center">
<Icon IconName="warning" Width="20" Height="20" Class="me-2 text-warning" />
<span class="fw-semibold">Deployment Failed - Manual Completion Required</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should say Deployment Failed - try again

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually this one is ok

<div class="alert alert-info mt-2">
<small class="text-muted">
<Icon IconName="info" Width="16" Height="16" Class="me-2" />
Completed steps have been saved. Continue manually from where the process stopped.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should say - Completed steps have been saved. Continue try again to from where the process stopped

dangershony
dangershony previously approved these changes Jun 15, 2025
Copy link
Member
@dangershony dangershony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok otherwise

@dangershony dangershony merged commit 3718cf1 into main Jun 15, 2025
3 checks passed
@dangershony dangershony deleted the create-project branch June 15, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0