-
Notifications
You must be signed in to change notification settings - Fork 33
Improved the structure and flow of the project creation wizard #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Angor/Client/Pages/Create.razor
Outdated
|
||
@if (!hasErrors && !isManualMode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this isManualMode and AutomaticMode?
If there was an error it goes to manual mode?
I see you kept the auto/manual mode but I don't think we need that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces two new utility classes to support fixed sizing within the project creation wizard’s layout.
- Adds a
.width-40
class for setting element width to 40px - Adds a
.height-40
class for setting element height to 40px
src/Angor/Client/Pages/Create.razor
Outdated
<div class="text-center mb-4"> | ||
<div class="alert alert-danger d-flex align-items-center justify-content-center"> | ||
<Icon IconName="warning" Width="20" Height="20" Class="me-2 text-warning" /> | ||
<span class="fw-semibold">Deployment Failed - Manual Completion Required</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should say Deployment Failed - try again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually this one is ok
src/Angor/Client/Pages/Create.razor
Outdated
<div class="alert alert-info mt-2"> | ||
<small class="text-muted"> | ||
<Icon IconName="info" Width="16" Height="16" Class="me-2" /> | ||
Completed steps have been saved. Continue manually from where the process stopped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should say - Completed steps have been saved. Continue try again to from where the process stopped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok otherwise
No description provided.