feat: Support partial path in data command
#275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b052f0e to
df2aab3
Compare
df2aab3 to
5d52453
Compare
|
@dobarx please take a look - there might be a better way to execute data blocks concurrently! |
traut
commented
Mar 13, 2025
| @@ -280,7 +280,8 @@ func fetchRSSData(ctx context.Context, params *plugin.RetrieveDataParams) (plugi | |||
| ctx, cancel := context.WithTimeout(ctx, defaultRequestTimeout) | |||
| defer cancel() | |||
|
|
|||
| log.InfoContext(ctx, "Downloading the feed", "feed_url", url) | |||
| log = log.With("feed_url", url) | |||
| log.InfoContext(ctx, "Downloading the feed") | |||
There was a problem hiding this comment.
an unrelated change, just improving logging
traut
commented
Mar 13, 2025
| grpc.MaxCallRecvMsgSize(defaultMsgSize), | ||
| grpc.MaxCallSendMsgSize(defaultMsgSize), | ||
| grpc.MaxCallRecvMsgSize(maxMsgSize), | ||
| grpc.MaxCallSendMsgSize(maxMsgSize), |
There was a problem hiding this comment.
an unrelated change, bumping a max msg size to 100MB
dobarx
reviewed
Mar 13, 2025
|
no idea why codegen check is failing, the command does not produce any changes locally for me :( I think it's some non-determinism in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial path in
datacommand enables execution of more than a single data block at a timePossible
pathoptions:<document-name>.data-- returns a dict with all data blocks executed<document-name>.data.<data-source>-- returns a dict with all data blocks of a particular type<document-name>.data.<data-source>.<block-name>-- returns a dict with a single matching data block