8000 Feat(build UI)/page structures by RyanCho-0 · Pull Request #54 · biyard/dagit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat(build UI)/page structures #54

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 7, 2025

Conversation

RyanCho-0
Copy link
Contributor
@RyanCho-0 RyanCho-0 commented Apr 7, 2025

Summary by CodeRabbit

  • New Features

    • Introduced a broad range of new pages across analytics, management, and orders, offering enhanced interfaces for reporting, traffic insights, and art-related management.
    • Added interactive modals for collection management, including dynamic filtering, creation, transfer confirmation, and success notifications.
  • Refactor / Improvements

    • Streamlined routing and navigation with standardized naming for clearer user transitions.
    • Updated Tailwind CSS integration and overall styling, ensuring improved theme consistency and responsive layouts.

@RyanCho-0 RyanCho-0 requested review from dotandev and a team as code owners April 7, 2025 09:08
@RyanCho-0 RyanCho-0 merged commit 99bdce4 into biyard:dev Apr 7, 2025
2 of 5 checks passed
Copy link
coderabbitai bot commented Apr 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request refactors the Tailwind CSS integration and reorganizes the project’s module structure. The CSS build process now uses a relocated input file and new public CSS files, with the removal of deprecated files and functions. At the same time, multiple new modules and components have been introduced under the agits section—including analytics, design, extension tool, hub, management, and orders—with updated route naming (adding “Page” suffix) and consolidated exports replacing outdated components.

Changes

Files Change Summary
Build and Tailwind Integration:
packages/build-ui/Makefile
packages/build-ui/input.css (deleted)
packages/build-ui/public/input.css
packages/build-ui/public/theme.css
packages/build-ui/tailwind-theme.css
packages/main-ui/Makefile
packages/main-ui/input.css (deleted)
packages/main-ui/public/input.css
packages/main-ui/public/theme.css
packages/build-ui/src/main.rs
packages/main-ui/src/main.rs
Updated the CSS build process: relocated CSS input file, removed obsolete theme files, introduced new public CSS files with theme imports, updated Makefile targets, and replaced the load_tailwindcss function with inline style and script elements.
Agits Module Restructure & New Pages:
packages/build-ui/src/pages/agits/_id/analytics/*
packages/build-ui/src/pages/agits/_id/design/*
packages/build-ui/src/pages/agits/_id/extension_tool/*
packages/build-ui/src/pages/agits/_id/hub/*
packages/build-ui/src/pages/agits/_id/management/*
packages/build-ui/src/pages/agits/_id/orders/*
packages/build-ui/src/pages/agits/_id/page.rs (legacy functions removed)
Introduced new modules and page components including ReportPage, TrafficPage, DesignPage, ExtensionToolPage, DaoPage, FaqPage, OraclePage, ArtistPage, ArtworkPage, CollectionPage, CollectorPage, SalesRequestPage, and ShippingLabelPage. Legacy component functions were removed in favor of reorganized and consolidated exports.
Routing and Navigation:
packages/build-ui/src/routes.rs
packages/build-ui/src/pages/agits/components/navigation/mod.rs
packages/build-ui/src/pages/agits/mod.rs
Renamed route variants to include a “Page” suffix; updated navigation links accordingly and consolidated public use declarations via a wildcard export.
Collections Components & Controller:
packages/build-ui/src/pages/agits/_id/management/collections/components/*
packages/build-ui/src/pages/agits/_id/management/collections/controllers.rs
packages/build-ui/src/pages/agits/_id/management/collections/i18n.rs
packages/build-ui/src/pages/agits/_id/management/collections/models.rs
packages/build-ui/src/pages/agits/_id/management/collections/page.rs
Added new UI components for managing collections (e.g., CollectionNameModal, FilterDropdown, FilterSidebar, NewCollectionModal, SuccessModal, TransferConfirmationModal) along with a corresponding controller, translations, data models, and a dedicated CollectionPage component.

Sequence Diagram(s)

sequenceDiagram
    participant App as App Component
    participant Style as document::Style
    participant Script as document::Script
    participant Tailwind as Tailwind CDN
    App->>Style: Load inline theme.css content
    App->>Script: Insert Tailwind CSS script tag
    Script->>Tailwind: Request Tailwind assets
    Tailwind-->>Script: Return Tailwind resources
Loading
sequenceDiagram
    participant User
    participant Nav as Navigation Component
    participant Router as Router
    participant Page as Page Component
    User->>Nav: Click route link (e.g., CollectionPage)
    Nav->>Router: Request route matching
    Router-->>Nav: Return matched route (CollectionPage)
    Nav->>Page: Render the CollectionPage component
Loading

Possibly related PRs

  • Features(build UI)/init #7: Addresses similar changes related to Tailwind CSS integration and the relocation of the input.css file within the build-ui package.

Suggested reviewers

  • dotandev
  • hackartists

Poem

In my burrow of code, I hop with delight,
Tailwind magic paints the day so bright,
New pages and routes now gracefully play,
Modular wonders guide my every stray,
A bunny’s whisper of progress, crisp and neat,
Carrot dreams in every line—a code retreat!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b7f9f86 and 71a2658.

📒 Files selected for processing (57)
  • packages/build-ui/Makefile (1 hunks)
  • packages/build-ui/input.css (0 hunks)
  • packages/build-ui/public/input.css (1 hunks)
  • packages/build-ui/public/theme.css (1 hunks)
  • packages/build-ui/src/main.rs (2 hunks)
  • packages/build-ui/src/pages/agits/_id/analytics/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/analytics/report/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/analytics/report/page.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/analytics/traffic/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/analytics/traffic/page.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/design/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/design/page.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/extension_tool/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/extension_tool/page.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/hub/dao/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/hub/dao/page.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/hub/faq/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/hub/faq/page.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/hub/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/hub/oracle/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/hub/oracle/page.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/artists/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/artists/page.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/artworks/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/artworks/page.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collecotrs/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collecotrs/page.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collections/components/collection_name_popup.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collections/components/filter_dropdown.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collections/components/filter_sidebar.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collections/components/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collections/components/new_collection_popup.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collections/components/success_popup.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collections/components/transfer_confirmation_popup.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collections/controllers.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collections/i18n.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collections/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collections/models.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/collections/page.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/management/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/orders/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/orders/sales_request/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/orders/sales_request/page.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/orders/shipping_label/mod.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/orders/shipping_label/page.rs (1 hunks)
  • packages/build-ui/src/pages/agits/_id/page.rs (0 hunks)
  • packages/build-ui/src/pages/agits/components/navigation/mod.rs (7 hunks)
  • packages/build-ui/src/pages/agits/layout.rs (1 hunks)
  • packages/build-ui/src/pages/agits/mod.rs (1 hunks)
  • packages/build-ui/src/routes.rs (1 hunks)
  • packages/build-ui/tailwind-theme.css (0 hunks)
  • packages/main-ui/Makefile (1 hunks)
  • packages/main-ui/input.css (0 hunks)
  • packages/main-ui/public/input.css (1 hunks)
  • packages/main-ui/public/theme.css (1 hunks)
  • packages/main-ui/src/main.rs (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0