[PM-19956] [PM-18795] Require provider payment method during setup behind FF #5752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5752 +/- ##
==========================================
- Coverage 50.43% 47.25% -3.18%
==========================================
Files 1633 1633
Lines 74211 74298 +87
Branches 6681 6692 +11
==========================================
- Hits 37425 35110 -2315
- Misses 35272 37734 +2462
+ Partials 1514 1454 -60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
r-tome
requested changes
Apr 30, 2025
bitwarden_license/src/Commercial.Core/AdminConsole/Services/ProviderService.cs
Show resolved
Hide resolved
bitwarden_license/test/Commercial.Core.Test/Billing/ProviderBillingServiceTests.cs
Outdated
Show resolved
Hide resolved
|
cyprain-okeke
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-19956
https://bitwarden.atlassian.net/browse/PM-18795
📔 Objective
This PR updates the Provider Setup Flow to require a payment method when the
pm-19956-require-provider-payment-method-during-setupflag is enabled.Full process updates include:
ProviderSetupRequestModelto require tax information now that Consolidated Billing is enshrined. It also adds an optionalPaymentSourceproperty that will be sent by the client when the feature flag is on.ProviderService.CompleteSetupAsyncmethod to take an optionalTokenizedPaymentSourcethat gets gleaned from the request in step 1. If the feature flag is on, it validates the payment source and passes it to theProviderBillingService.SetupCustomermethod.ProviderBillingService.SetupCustomermethod to take this optionalTokenizedPaymentSourceand, if the feature flag is on and the payment source is sent, it attaches the payment source to the newly created customer.ProviderBillingService.StartSubscriptionmethod so that when the feature flag is on and the customer has an attached payment method, it sets the provider subscription tocharge_automaticallywith a trial length of 14 days per PM-19795.Associated Clients PR: bitwarden/clients#14550
📸 Screenshots
Card
Screen.Recording.2025-04-29.at.11.27.47.AM.mov
Bank Account
Screen.Recording.2025-04-29.at.11.41.01.AM.mov
PayPal
Screen.Recording.2025-04-29.at.11.42.31.AM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes