Support new export methods #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godrei
reviewed
Apr 8, 2025
xcodeversion/xcodeversion.go
Outdated
| @@ -33,10 +34,21 @@ func NewXcodeVersionProvider(commandFactory command.Factory) Reader { | |||
| func (b *reader) GetVersion() (Version, error) { | |||
| cmd := b.commandFactory.Create("xcodebuild", []string{"-version"}, &command.Opts{}) | |||
|
|
|||
| outStr, err := cmd.RunAndReturnTrimmedCombinedOutput() | |||
| outStr, err := cmd.RunAndReturnTrimmedOutput() | |||
There was a problem hiding this comment.
What's the reason for this change?
There was a problem hiding this comment.
Was thinking that this way we ignore errors printed to stderr. But as now we use regexp based parsing, it should not really make a difference, can revert this.
godrei
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Xcode 15.3, distribution methods have been renamed. The values of this input reflect the old names. When running with Xcode 15.3 and later, the new names are passed to xcodebuild:
debugging, when development is selected
app-store-connect, when app-store is selected
release-testing, when ad-hoc is selected
enterprise is unchanged
Updated xcodeversion.Reader to read minor xcode version