-
Notifications
You must be signed in to change notification settings - Fork 1
Initial Commit #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small bits of tidying
@@ -0,0 +1,30 @@ | |||
export const upgradeScripts = [ | |||
function v2_1(context, props) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this upgrade script needed? the name of it suggests it isnt relevant for your module?
}, | ||
"license": "MIT", | ||
"dependencies": { | ||
"@companion-module/base": "~1.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update this library to something newer (perhaps "~1.11.3")
"url": "git+https://github.com/bitfocus/companion-module-cuego-ws.git" | ||
}, | ||
"devDependencies": { | ||
"@companion-module/tools": "^1.0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for this, "^2.3.0" is the latest
{ | ||
type: 'checkbox', | ||
id: 'append_new_line', | ||
8000 | label: 'Append new line', | |
tooltip: 'Append new line (\\r\\n) to cuego', | ||
width: 6, | ||
default: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this being used anywhere (except for the upgrade script). Should it be removed?
No description provided.