8000 Initial Commit by firefli-uk · Pull Request #1 · bitfocus/companion-module-cuego-ws · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Initial Commit #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Initial Commit #1

wants to merge 1 commit into from

Conversation

firefli-uk
Copy link

No description provided.

Copy link
Member
@Julusian Julusian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small bits of tidying

@@ -0,0 +1,30 @@
export const upgradeScripts = [
function v2_1(context, props) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this upgrade script needed? the name of it suggests it isnt relevant for your module?

},
"license": "MIT",
"dependencies": {
"@companion-module/base": "~1.2.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update this library to something newer (perhaps "~1.11.3")

"url": "git+https://github.com/bitfocus/companion-module-cuego-ws.git"
},
"devDependencies": {
"@companion-module/tools": "^1.0.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for this, "^2.3.0" is the latest

Comment on lines +254 to +261
8000
{
type: 'checkbox',
id: 'append_new_line',
label: 'Append new line',
tooltip: 'Append new line (\\r\\n) to cuego',
width: 6,
default: true,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this being used anywhere (except for the upgrade script). Should it be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0