Newsletters: add 308 (2024-06-21) #1735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryRuane
reviewed
Jun 17, 2024
|
|
||
| - **Continued discussion of PSBTs for silent payments:** several | ||
| developers have been discussing adding support for coordinating the | ||
| sending [silent payments][topic silent payments] using [PSBTs][topic |
There was a problem hiding this comment.
Suggested change
| sending [silent payments][topic silent payments] using [PSBTs][topic | |
| sending of [silent payments][topic silent payments] using [PSBTs][topic |
| - **Continued discussion of PSBTs for silent payments:** several | ||
| developers have been discussing adding support for coordinating the | ||
| sending [silent payments][topic silent payments] using [PSBTs][topic | ||
| psbt]. Since our [previous summary][news304 sp-psbt], discussion has |
There was a problem hiding this comment.
Suggested change
| psbt]. Since our [previous summary][news304 sp-psbt], discussion has | |
| psbt]. Since our [previous summary][news304 sp-psbt], the discussion has |
| (or multiple keys with multiple output scripts if multiple silent | ||
| payments are being made in the same transaction). | ||
|
|
||
| After all of the transaction's output scripts are known, each signer |
There was a problem hiding this comment.
Suggested change
| After all of the transaction's output scripts are known, each signer | |
| After the transaction's output scripts are known, each signer |
(minor suggestion, I think slightly better but probably okay as is, just an idea to consider)
|
|
||
| After all of the transaction's output scripts are known, each signer | ||
| re-processes the PSBT to add their signatures. This results in a | ||
| two-round process for complete signing of the PSBT (in addition to any |
There was a problem hiding this comment.
Suggested change
| two-round process for complete signing of the PSBT (in addition to any | |
| two-round process for the complete signing of the PSBT (in addition to any |
|
May I suggest adding bitcoin/bitcoin#29325 to notable code changes? It's highly relevant to the btcd concensus failure described a few months ago in Newsletter #286. |
|
Made edits for @LarryRuane feedback (thanks!) and added a summary of the recent LND security disclosure. |
vostrnad
reviewed
Jun 19, 2024
|
|
||
| LND accepted a payload's indicated size up to 4 gigabytes and would | ||
| allocate that amount of memory before further processing the payload. | ||
| This is enough exhaust the memory of some LND nodes, resulting in them |
There was a problem hiding this comment.
Suggested change
| This is enough exhaust the memory of some LND nodes, resulting in them | |
| This is enough to exhaust the memory of some LND nodes, resulting in them |
| crashing or being terminated by the operating system, and it could be | ||
| used to crash nodes that had more memory by sending multiple onion | ||
| packets constructed this way. A crashed LN node cannot send | ||
| time-sensitive transaction that may be necessary to protect its funds, |
There was a problem hiding this comment.
Suggested change
| time-sensitive transaction that may be necessary to protect its funds, | |
| time-sensitive transactions that may be necessary to protect its funds, |
LarryRuane
reviewed
Jun 20, 2024
| allocate that amount of memory before further processing the payload. | ||
| This is enough exhaust the memory of some LND nodes, resulting in them | ||
| crashing or being terminated by the operating system, and it could be | ||
| used to crash nodes that had more memory by sending multiple onion |
There was a problem hiding this comment.
Suggested change
| used to crash nodes that had more memory by sending multiple onion | |
| used to crash nodes that have more memory by sending multiple onion |
| two-round process for the complete signing of the PSBT (in addition to any | ||
| other rounds required by other protocols, such as [MuSig2][topic | ||
| musig]). However, if there's only one signer for the entire | ||
| transaction (e.g. the PSBT is simply being sent to a hardware signing |
There was a problem hiding this comment.
Suggested change
| transaction (e.g. the PSBT is simply being sent to a hardware signing | |
| transaction (e.g. the PSBT is being sent to a hardware signing |
|
|
||
| - **Volt Wallet beta announced:** | ||
| [Volt Wallet][volt github] supports descriptors, [taproot][topic taproot], | ||
| [PSBTs][topic psbt], Lightning, among other BIPs. |
There was a problem hiding this comment.
Suggested change
| [PSBTs][topic psbt], Lightning, among other BIPs. | |
| [PSBTs][topic psbt], and Lightning, among other BIPs. |
| - **Constant-time analysis tool cargo-checkct announced:** | ||
| A Ledger [blog post][ledger cargo-checkct blog] announced | ||
| [cargo-checkct][cargo-checkct github], a tool that evaluates whether Rust | ||
| cryptographic libraries run in constant-time, in an effort to avoid [timing |
There was a problem hiding this comment.
Suggested change
| cryptographic libraries run in constant-time, in an effort to avoid [timing | |
| cryptographic libraries run in constant time to avoid [timing |
|
Added remaining content, reviewed @bitschmidty and @Gustavojfe sections (great!), and added topic entries. Thanks everyone! |
1fbbe62 to
17b0fb8
Compare
bitschmidty
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Pushed a change for a few fixups I noticed, reviewed lede, topics, and updates. Squashed.
Thanks @harding for authoring providing final notable code summaries, @Gustavojfe for authoring, and @vostrnad and @LarryRuane for reviewing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.