8000 [28.x] Finalize 28.2 by achow101 · Pull Request #32766 · bitcoin/bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[28.x] Finalize 28.2 #32766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2025
Merged

[28.x] Finalize 28.2 #32766

merged 3 commits into from
Jun 19, 2025

Conversation

achow101
Copy link
Member

Version bump for 28.2 final

@DrahtBot
Copy link
Contributor
DrahtBot commented Jun 17, 2025 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32766.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK theStack, fanquake
Stale ACK glozow, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@fanquake fanquake added this to the 28.2 milestone Jun 17, 2025
glozow
glozow reviewed Jun 17, 2025
View reviewed changes
Copy link
Member
@glozow glozow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ACK 90f78c7

hebasto
hebasto approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member
@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 90f78c7.

@fanquake
Copy link
Member

release-notes.md is still 28.2rc2.

@achow101
Copy link
Member Author

release-notes.md is still 28.2rc2.

Oops, done.

@theStack
Copy link
Contributor

ACK (modulo "Thanks to ..." sentence in release notes should go before list of names, see also bitcoin-core/bitcoincore.org#1100 (comment))

@achow101
Copy link
Member Author

ACK (modulo "Thanks to ..." sentence in release notes should go before list of names, see also bitcoin-core/bitcoincore.org#1100 (comment))

Fixed

theStack
theStack approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor
@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7135d75

@DrahtBot DrahtBot requested review from hebasto and glozow June 18, 2025 23:06
fanquake
fanquake approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member
@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7135d75

@fanquake fanquake merged commit e44d72b into bitcoin:28.x Jun 19, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theStack theStack theStack approved these changes

@fanquake fanquake fanquake approved these changes

@hebasto hebasto Awaiting requested review from hebasto

@glozow glozow Awaiting requested review from glozow

Assignees
No one assigned
Labels
Backport CI failed
Projects
None yet
Milestone
28.2
Development

Successfully merging this pull request may close these issues.
6 participants
@achow101 @DrahtBot @fanquake @theStack @glozow @hebasto
0