8000 Update libmultiprocess subtree to fix clang-tidy errors by ryanofsky · Pull Request #32641 · bitcoin/bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update libmultiprocess subtree to fix clang-tidy errors #32641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

Update libmultiprocess subtree to fix clang-tidy errors #32641

merged 2 commits into from
May 30, 2025

Conversation

ryanofsky
Copy link
Contributor

ryanofsky added 2 commits May 29, 2025 13:57
@ryanofsky
Squashed 'src/ipc/libmultiprocess/' changes from 35944ffd23fa..27c7e8…
154af1e 
…e5a581

27c7e8e5a581 Merge bitcoin-core/libmultiprocess#172: refactor: fix warnings from clang-tidy-20 and bitcoin-tidy
2fe87d016be4 Merge bitcoin-core/libmultiprocess#173: doc: Fix error string typo
57a65b854664 clang-tidy: Suppress bitcoin-nontrivial-threadlocal error
0d8012f656fe Merge bitcoin-core/libmultiprocess#165: clang-tidy: fix warnings introduced in version 19
3a96cdc18f2d clang-tidy: Fix bugprone-move-forwarding-reference error
c1e8c1a02864 clang-tidy: Fix bugprone-move-forwarding-reference errors
aa19285303ff use ranges transform
a78137ca73b8 make member function const
ca3226ec8ab7 replace custom tuple unpacking code with `std::apply`
949fe85fc91f replace SFINAE trick with `if constexpr`
44ee4b40b89a doc: Fix error string typo

git-subtree-dir: src/ipc/libmultiprocess
git-subtree-split: 27c7e8e5a581b3c41330e758951251ef11807b11
@ryanofsky
Merge commit '154af1eea1170f5626aa1c5f19cc77d1434bcc9d' into HEAD
9f65654
@DrahtBot
Copy link
Contributor
DrahtBot commented May 29, 2025 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32641.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK TheCharlatan, Sjors

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

TheCharlatan
TheCharlatan approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor
@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9f65654

@Sjors
Copy link
Member
Sjors commented May 30, 2025 •
edited
Loading

ACK 9f65654

Tested with git-subtree-check.sh -r

I reviewed bitcoin-core/libmultiprocess#172 myself, but for the other pull requests I only glanced over the final diff here.

For future subtree updates we may also want to do bitcoin-core/libmultiprocess#178. That would give some assurance that the correct merge policy is followed there.

@fanquake fanquake merged commit 9393aee into bitcoin:master May 30, 2025
19 checks passed
@Sjors Sjors mentioned this pull request May 30, 2025
Open
ryanofsky added a commit to ryanofsky/libmultiprocess that referenced this pull request Jun 3, 2025
@ryanofsky
type-function.h: Fix CustomBuildField overload
8b96229 
Fix std::function CustomBuildField overload which is incompatible with a recent
change in 3a96cdc from
bitcoin-core#172 which changed
generated IPC client code to pass it an rvalue std::function reference instead
of an lvalue reference.

There was no test coverage for the type-function.h header earlier but the next
commit adds a test which would have caught the problem in the CustomBuildField
declaration.

Motivation for this change is to avoid a build error in
bitcoin/bitcoin#29409 when rebased on top of
bitcoin/bitcoin#32641 which includes
bitcoin-core#172
This was referenced Jun 3, 2025
Merged
Open
ryanofsky added a commit to ryanofsky/libmultiprocess that referenced this pull request Jun 5, 2025
@ryanofsky
type-function.h: Fix CustomBuildField overload
a1ca076 
Fix std::function CustomBuildField overload which is incompatible with a recent
change in 3a96cdc from
bitcoin-core#172 which changed
generated IPC client code to pass it an rvalue std::function reference instead
of an lvalue reference.

There was no test coverage for the type-function.h header earlier but the next
commit adds a test which would have caught the problem in the CustomBuildField
declaration.

Motivation for this change is to avoid a build error in
bitcoin/bitcoin#29409 when rebased on top of
bitcoin/bitcoin#32641 which includes
bitcoin-core#172
@ryanofsky ryanofsky mentioned this pull request Jun 5, 2025
Open
ryanofsky added a commit to bitcoin-core/libmultiprocess that referenced this pull request Jun 11, 2025
@ryanofsky
Merge #181: type-function.h: Fix CustomBuildField overload
59030c6 
688140b test: Add coverage for type-function.h (Ryan Ofsky)
8b96229 type-function.h: Fix CustomBuildField overload (Ryan Ofsky)

Pull request description:

  Fix `std::function` `CustomBuildField` overload which is incompatible with a recent change in 3a96cdc from #172 which changed generated IPC client code to pass it an rvalue `std::function` reference instead of an lvalue reference.

  Motivation for this change is to avoid a build error in bitcoin/bitcoin#29409, when rebased on top of bitcoin/bitcoin#32641 which includes #172.

ACKs for top commit:
  TheCharlatan:
    ACK 688140b

Tree-SHA512: aeb5cbea0b4aaf7f84c4c30255546f367c4c6ca154c831f648f6ba03599b23beb7032477599671c10da790ff2ff592ae8ce3098bee294b431cfca82b1530f42d
TheCharlatan added a commit to TheCharlatan/rust-bitcoinkernel that referenced this pull request Jun 14, 2025
@TheCharlatan
Squashed 'libbitcoinkernel-sys/bitcoin/' changes from 9f83f8b46c84..d…
f236a50 
…9e030d56343

d9e030d56343 kernel: Fix bitcoin-chainstate for windows
cc4ac564cc38 kernel: Add Purpose section to header documentation
bfdf605296ce kernel: Add pure kernel bitcoin-chainstate
35099f39b7ea kernel: Add functions to get the block hash from a block
fae94070a72e kernel: Add block index utility functions to C header
d5d377859785 kernel: Add function to read block undo data from disk to C header
43f6039b7b48 kernel: Add functions to read block from disk to C header
54cdfcdc68e6 kernel: Add function for copying block data to C header
18cab45358c3 kernel: Add functions for the block validation state to C header
033e86a06cbc kernel: Add validation interface to C header
9398f9ea4e14 kernel: Add interrupt function to C header
86340a490541 kernel: Add import blocks function to C header
f11dc01bba94 kernel: Add chainstate load options for in-memory dbs in C header
be9fc18dd54f kernel: Add options for reindexing in C header
7947a9b500fc kernel: Add block validation to C header
d5ace1f8ea96 kernel: Add chainstate loading when instantiating a ChainstateManager
47ff652cf08f kernel: Add chainstate manager option for setting worker threads
106898e0c25f kernel: Add chainstate manager object to C header
3eadf1ccbe1c kernel: Add notifications context option to C header
98b1454a987a kernel: Add chain params context option to C header
ca8d6ee344b7 kernel: Add kernel library context object
96f5ebe97748 kernel: Add logging to kernel library C header
906a19748152 kernel: Introduce initial kernel C header API
4b8ac9eacd1b Merge bitcoin/bitcoin#32680: ci: Rewrite test-each-commit as py script
157bbd0a07c0 Merge bitcoin/bitcoin#32425: config: allow setting -proxy per network
ebec7bf3895c Merge bitcoin/bitcoin#32572: doc: Remove stale sections in dev notes
011a8c5f0168 Merge bitcoin/bitcoin#32696: doc: make `-DWITH_ZMQ=ON` explicit on `build-unix.md`
fe39050a66c7 Merge bitcoin/bitcoin#32678: guix: warn and abort when SOURCE_DATE_EPOCH is set
692fe280c232 Merge bitcoin/bitcoin#32713: doc: fuzz: fix AFL++ link
c1d4253d316e Merge bitcoin/bitcoin#32711: doc: add missing packages for BSDs (cmake, gmake, curl) to depends/README.md
89526deddf87 doc: add missing packages for BSDs (cmake, gmake, curl) to depends/README.md
a39b7071cfb4 doc: fuzz: fix AFL++ link
dff208bd5a14 Merge bitcoin/bitcoin#32708: rpc, doc: update `listdescriptors` RCP help
d978a43d054d Merge bitcoin/bitcoin#32408: tests: Expand HTTP coverage to assert libevent behavior
f3bbc746647d Merge bitcoin/bitcoin#32406: policy: uncap datacarrier by default
b44514b87633 rpc, doc: update `listdescriptors` RCP help
32d4e92b9ac8 doc: make `-DWITH_ZMQ=ON` explicit on `build-unix.md`
e2174378aa8a Merge bitcoin/bitcoin#32539: init: Configure reachable networks before we start the RPC server
2053c4368472 Merge bitcoin/bitcoin#32675: test: wallet: cover wallet passphrase with a null char
fa9cfdf3be75 ci: [doc] fix url redirect
fac60b9c4839 ci: Rewrite test-each-commit as py script
ae024137bda9 Merge bitcoin/bitcoin#32496: depends: drop `ltcg` for Windows Qt
6a2ff6790929 Merge bitcoin/bitcoin#32679: doc: update tor docs to use bitcoind binary from path
fd4399cb9c69 Merge bitcoin/bitcoin#32602: fuzz: Add target for coins database
f94167512dc9 Merge bitcoin/bitcoin#32676: test: apply microsecond precision to test framework logging
0dcb45290cf8 Merge bitcoin/bitcoin#32607: rpc: Note in fundrawtransaction doc, fee rate is for package
4ce53495e5e1 doc: update tor docs to use bitcoind binary from path
a5e98dc3ae63 Merge bitcoin/bitcoin#32651: cmake: Replace deprecated `qt6_add_translation` with `qt6_add_lrelease`
9653ebc05360 depends: remove support for Windows Qt LTO builds
7cfbb8575e1f test: wallet: cover wallet passphrase with a null char
5c4a0f8009ce guix: warn and abort when SOURCE_DATE_EPOCH is set
4af72d8b0892 Merge bitcoin/bitcoin#32647: build: add -Wthread-safety-pointer
a980918f51d7 Merge bitcoin/bitcoin#32568: depends: use "mkdir -p" when installing xproto
ed179e0a6528 test: apply microsecond precision to test framework logging
e872a566f251 Merge bitcoin/bitcoin#32644: doc: miscellaneous changes
e50312eab0b5 doc: fix typos
c797e50ddae9 ci: update codespell to 2.4.1
21ee656337b0 doc: Remove obselete link in notificator.cpp
ee4406c04af0 doc: update URLs
2d819fa4dff9 Merge bitcoin/bitcoin#29032: signet: omit commitment for some trivial challenges
f999c3775c12 Merge bitcoin/bitcoin#32449: wallet: init, don't error out when loading legacy wallets
f98e1aaf34e3 rpc: Note in fundrawtransaction doc, fee rate is for package
1c6602399be6 Merge bitcoin/bitcoin#32662: doc: Remove build instruction for running `clang-tidy`
4b1b36acb48f doc: Remove build instruction for running `clang-tidy`
9e105107bf52 Merge bitcoin/bitcoin#32656: depends: don't install & then delete sqlite pkgconf
72a5aa9b791e depends: don't install & then delete sqlite pkgconf
18cf727429e9 cmake: Replace deprecated `qt6_add_translation` with `qt6_add_lrelease`
83bfe1485c37 build: add -Wthread-safety-pointer
e639ae05315e Update leveldb subtree to latest upstream
240a4fb95d5b Squashed 'src/leveldb/' changes from 113db4962b..aba469ad6a
a189d636184b add release note for datacarriersize default change
a141e1bf501b Add more OP_RETURN mempool acceptance functional tests
0b4048c73385 datacarrier: deprecate startup arguments for future removal
63091b79e70b test: remove unnecessary -datacarriersize args from tests
9f36962b07ef policy: uncap datacarrier by default
4b1d48a6866b Merge bitcoin/bitcoin#32598: walletdb: Log additional exception error messages for corrupted wallets
b933813386ef Merge bitcoin/bitcoin#32619: wallet, rpc, gui: List legacy wallets with a message about migration
053bda5d9fb3 Merge bitcoin/bitcoin#32460: fs: remove `_POSIX_C_SOURCE` defining
9393aeeca4b1 Merge bitcoin/bitcoin#32641: Update libmultiprocess subtree to fix clang-tidy errors
5471e29d0570 Merge bitcoin/bitcoin#32304: test: test MAX_SCRIPT_SIZE for block validity
9f6565488fc1 Merge commit '154af1eea1170f5626aa1c5f19cc77d1434bcc9d' into HEAD
154af1eea117 Squashed 'src/ipc/libmultiprocess/' changes from 35944ffd23fa..27c7e8e5a581
c540ede1cbca Merge bitcoin/bitcoin#32633: windows: Use predefined `RC_INVOKED` macro instead of custom one
cfc42ae5b7ef fuzz: add a target for the coins database
55f1c2ac8beb windows: Use predefined `RC_INVOKED` macro instead of custom one
14c16e81598a Merge bitcoin/bitcoin#32582: log: Additional compact block logging
aad5938c49f9 Merge bitcoin/bitcoin#32516: test: add MAX_DISCONNECTED_TX_POOL_BYTES, chainlimits coverage
1062df81eec7 Merge bitcoin/bitcoin#32634: build: Add resource file and manifest to `bitcoin.exe`
83df64d7491b log: Stats when fulfilling GETBLOCKTXN
370c59261269 Merge bitcoin/bitcoin#32630: test: fix sync function in rpc_psbt.py
dbb2d4c3d547 windows: Add application manifest to `bitcoin.exe`
df82c2dc17e3 windows: Add resource file for `bitcoin.exe`
3733ed2dae3d log: Size of missing tx'es when reconstructing compact block
4df4df45d7bc test: fix sync function in rpc_psbt.py
84aa484d45e2 test: fix transaction_graph_test reorg test
eaf44f376784 test: check chainlimits respects on reorg
47894367b583 functional test: add MAX_DISCONNECTED_TX_POOL_BYTES coverage
f3a444c45fb4 gui: Disallow loading legacy wallets
09955172f38a wallet, rpc: Give warning in listwalletdir for legacy wallets
ad9a13fc424e walletdb: Log additional exception error messages for corrupted wallets
46e14630f7fe fuzz: move the coins_view target's body into a standalone function
56d878c4650c fuzz: avoid underflow in coins_view target
36bcee05dc71 log: Log start of compact block initialization.
24e5fd3bedce fs: remove _POSIX_C_SOURCE defining
f16c8c67bf13 tests: Expand HTTP coverage to assert libevent behavior
fac00d4ed361 doc: Move CI-must-pass requirement into readme section
fab79c1a250d doc: Clarify and move "hygienic commit" note
fac8b0519799 doc: Clarify strprintf size specifier note
faaf34ad7253 doc: Remove section about RPC alias via function pointer
2222d61e1ce5 doc: Remove section about RPC arg names in table
fa00b8c02c9d doc: Remove section about include guards
fad6cd739b63 doc: Remove dev note section on includes
fa6623d85af1 doc: Remove file name section
7777fb8bc749 doc: Remove shebang section
faf65f05312b doc: Remove .gitignore section
faf2094f2511 doc: Remove note about removed ParsePrechecks
fa69c5b170f5 doc: Remove -disablewallet from dev notes
df9ebbf659d5 depends: use "mkdir -p" when installing xproto
6ee32aaaca4a test: signet tool genpsbt and solvepsbt commands
0a99d99fe4cb signet: miner skips PSBT step for OP_TRUE
cdfb70e5a6a9 signet: split decode_psbt miner helper
86e1111239cd test: verify node skips loading legacy wallets during startup
12ff4be9c724 test: ensure -rpcallowip is compatible with RFC4193
c02bd3c1875a config: Explain RFC4193 and CJDNS interaction in help and init error
f728b6b11100 init: Configure reachable networks before we start the RPC server
9f94de5bb54f wallet: init, don't error out when loading legacy wallets
e98c51fcce9a doc: update tor.md to mention the new -proxy=addr:port=tor
ca5781e23a8f config: allow setting -proxy per network
b1ea542ae651 test: test MAX_SCRIPT_SIZE for block validity
REVERT: 9f83f8b46c84 kernel: build monolithic static lib
REVERT: 1417e0b3b1b0 kernel: Fix bitcoin-chainstate for windows
REVERT: 4f07590a8bd6 kernel: Add Purpose section to header documentation
REVERT: 58c01a82c163 kernel: Add pure kernel bitcoin-chainstate
REVERT: 0416a292f545 kernel: Add functions to get the block hash from a block
REVERT: 8d25dfd1b2a2 kernel: Add block index utility functions to C header
REVERT: eacf99dd3c28 kernel: Add function to read block undo data from disk to C header
REVERT: 3c012048c2f1 kernel: Add functions to read block from disk to C header
REVERT: 85f5264462e0 kernel: Add function for copying block data to C header
REVERT: f136ca589153 kernel: Add functions for the block validation state to C header
REVERT: 9d7e19ee522d kernel: Add validation interface to C header
REVERT: 51555301a882 kernel: Add interrupt function to C header
REVERT: 61c4ac9c8e1f kernel: Add import blocks function to C header
REVERT: 4153ab77084e kernel: Add chainstate load options for in-memory dbs in C header
REVERT: cb128288a0d9 kernel: Add options for reindexing in C header
REVERT: 7ead2a92be50 kernel: Add block validation to C header
REVERT: 9262ce715448 kernel: Add chainstate loading when instantiating a ChainstateManager
REVERT: 594b060da476 kernel: Add chainstate manager option for setting worker threads
REVERT: 7384b7325d5f kernel: Add chainstate manager object to C header
REVERT: 7920e23c22b8 kernel: Add notifications context option to C header
REVERT: c0a86769e784 kernel: Add chain params context option to C header
REVERT: 3769d12882f9 kernel: Add kernel library context object
REVERT: f7b435493bd7 kernel: Add logging to kernel library C header
REVERT: 62d0122c7ed0 kernel: Introduce initial kernel C header API

git-subtree-dir: libbitcoinkernel-sys/bitcoin
git-subtree-split: d9e030d56343bb452d86169f77ddfb64f7160235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheCharlatan TheCharlatan TheCharlatan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryanofsky @DrahtBot @Sjors @TheCharlatan @fanquake
0