test: mining_getblocktemplate_longpoll.py improvements (use MiniWallet, add logging) #20159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Oct 16, 2020
This test can now be run even with the Bitcoin Core wallet disabled.
c63e7c2 to
ae69e09
Compare
|
Updated PR description and force-pushed with the feedback from MarcoFalke taken into account. |
ae69e09 to
b128b56
Compare
maflcko
approved these changes
Oct 16, 2020
|
ACK b128b56 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 18, 2020
…ements (use MiniWallet, add logging) b128b56 test: add logging for mining_getblocktemplate_longpoll.py (Sebastian Falbesoner) 8ee3536 test: remove unused helpers random_transaction(), make_change() and gather_inputs() (Sebastian Falbesoner) fddce7e test: use MiniWallet for mining_getblocktemplate_longpoll.py (Sebastian Falbesoner) Pull request description: This PR enables one more of the non-wallet functional tests (mining_getblocktemplate_longpoll.py) to be run even with the Bitcoin Core wallet disabled by using the new MiniWallet instead, as proposed in bitcoin#20078. Also adds missing log messages for the subtests. This was the only functional test that used the `random_transaction` helper in `test_framework/util.py`, hence it is removed, together with other helpers (`make_change` and `gather_inputs`) that were again only used by `random_transaction`. ACKs for top commit: MarcoFalke: ACK b128b56 Tree-SHA512: 09a5fa7b0f5976a47040f7027236d7ec0426d5a4829a082221c4b5fae294470230e89ae3df0bca0eea26833162c03980517f5cc88761ad251c3df4c4a49bca46
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 25, 2021
Summary: This test can now be run even with the Bitcoin ABC wallet disabled. This is a backport of [[bitcoin/bitcoin#20159 | core#20159]] [1/3] bitcoin/bitcoin@fddce7e Test Plan: `test/functional/test_runner.py mining_getblocktemplate_longpoll` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10517
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 25, 2021
…ather_inputs() Summary: This is a backport of [[bitcoin/bitcoin#20159 | core#20159]] [2/3] bitcoin/bitcoin@8ee3536 Depends on D10517 Test Plan: `ninja check-functional-extended` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10518
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 25, 2021
Summary: This is a backport of [[bitcoin/bitcoin#20159 | core#20159]] [3/3] bitcoin/bitcoin@b128b56 Depends on D10518 Test Plan: `test/functional/test_runner.py mining_getblocktemplate_longpoll` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10519
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables one more of the non-wallet functional tests (mining_getblocktemplate_longpoll.py) to be run even with the Bitcoin Core wallet disabled by using the new MiniWallet instead, as proposed in #20078. Also adds missing log messages for the subtests.
This was the only functional test that used the
random_transactionhelper intest_framework/util.py, hence it is removed, together with other helpers (make_changeandgather_inputs) that were again only used byrandom_transaction.