8000 refactor: importpubkey, importprivkey, importaddress, importmulti, and importdescriptors rpc by KolbyML · Pull Request #26840 · bitcoin/bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: importpubkey, importprivkey, importaddress, importmulti, and importdescriptors rpc #26840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

refactor: importpubkey, importprivkey, importaddress, importmulti, and importdescriptors rpc #26840

wants to merge 3 commits into from

Conversation

KolbyML
Copy link
Contributor
@KolbyML KolbyML commented Jan 7, 2023 •
edited
Loading

This is a wallet rpc refactor from my gui pr bitcoin-core/gui#650

I was told by a contributor I should make a pr here for anything not in src/qt except for makefile/.ui stuff

So this pr refactors the RPC code so that it can be used through interfaces so there isn't a ton of code duplication more details would be in my bitcoin-core/gui pr.

For context this is apart of my Summer of Bitcoin project achow101 was my mentor.

@DrahtBot
Copy link
Contributor
DrahtBot commented Jan 7, 2023 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #29675 (wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys by achow101)
  • #29280 (Implement OP_CHECKTEMPLATEVERIFY by reardencode)
  • #29136 (wallet: addhdkey RPC to add just keys to wallets via new void(KEY) descriptor by achow101)
  • #29050 (Add OP_TXHASH and OP_CHECKTXHASHVERIFY opcodes by stevenroose)
  • #28336 (rpc: parse legacy pubkeys consistently with specific error messages by theStack)
  • #27865 (wallet: Track no-longer-spendable TXOs separately by achow101)
  • #27351 (wallet: add seeds argument to importdescriptors by apoelstra)
  • #27286 (wallet: Keep track of the wallet's own transaction outputs in memory by achow101)
  • #25979 ([WIP] wallet: standardize change output detection process by furszy)
  • #22838 (descriptors: Be able to specify change and receiving in a single descriptor string by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@KolbyML KolbyML marked this pull request as draft January 7, 2023 01:32
@KolbyML KolbyML force-pushed the refactor-imports branch 5 times, most recently from c284727 to 45c71bf Compare January 7, 2023 02:48
@KolbyML KolbyML marked this pull request as ready for review January 7, 2023 03:53
This was referenced Jan 7, 2023
Merged
Closed
Closed
Merged
Merged
Closed
@DrahtBot DrahtBot mentioned this pull request Jan 10, 2023
Closed
@KolbyML KolbyML force-pushed the refactor-imports branch 5 times, most recently from de77e45 to 206def7 Compare January 12, 2023 16:55
@DrahtBot DrahtBot mentioned this pull request Jan 13, 2023
Closed
3 tasks
@DrahtBot DrahtBot mentioned this pull request Jan 21, 2023
Closed
@fanquake
Copy link
Member

@achow101 any thoughts on the best way/time to merge this? Conflicting with a lot of other changes.

@KolbyML KolbyML force-pushed the refactor-imports branch 2 times, most recently from e60d258 to aa67ca4 Compare February 19, 2023 05:16
@KolbyML KolbyML force-pushed the refactor-imports branch 2 times, most recently from 8fd8291 to 4fff303 Compare April 12, 2023 19:50
@KolbyML KolbyML force-pushed the refactor-imports branch from 4fff303 to 20b19e7 Compare May 2, 2023 20:06
This was referenced Jun 5, 2023
Closed
Draft
@DrahtBot DrahtBot mentioned this pull request Jul 22, 2023
Closed
@DrahtBot DrahtBot mentioned this pull request Aug 2, 2023
Closed
@DrahtBot DrahtBot mentioned this pull request Aug 24, 2023
Merged
@DrahtBot
Copy link
Contributor
DrahtBot commented Sep 4, 2023

Needs rebase if still relevant

@DrahtBot DrahtBot marked this pull request as draft September 10, 2023 18:05
@DrahtBot DrahtBot mentioned this pull request Sep 11, 2023
Closed
@DrahtBot DrahtBot mentioned this pull request Sep 28, 2023
Closed
@DrahtBot DrahtBot mentioned this pull request Oct 24, 2023
Merged
This was referenced Dec 5, 2023
Closed
Closed
This was referenced Jan 5, 2024
Open
Closed
Closed
@DrahtBot DrahtBot mentioned this pull request Jan 19, 2024
Closed
@DrahtBot DrahtBot mentioned this pull request Mar 19, 2024
Draft
@KolbyML
Copy link
Contributor Author
KolbyML commented Mar 20, 2024

closing due to bitcoin-core/gui#650 (comment)

@KolbyML KolbyML closed this Mar 20, 2024
@bitcoin bitcoin locked and limited conversation to collaborators Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CI failed Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KolbyML @DrahtBot @fanquake
0