build: Automatically include both git-tracked and bootstrapped files.
#18478
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Meta question: could we described the "users" of bootstrapped files? What systems they are use? What are their workflows? etc. I suppose a user of the Bitcoin Core, who is willing to build his binaries from sources, runs a non-unusual Linux distro, and is able to start build with |
|
In my mind, including bootstrapped files (and effectively pinning the autotools version) is better than not including them. Why would we not also include bootstrapped files if it's easy to do? |
|
Concept ACK. Travis out-of-tree builds are failing. |
864bc27 to
f2ba8ec
Compare
This allows us to: 1. Retain the automatic inclusion of bootstrapped files inside dist source tarballs 2. Also automatically include all git-tracked files in EXTRA_DIST Notes: 1. We already rely on git for `make dist` anyway (see dist-hook). 2. As of automake:77d39959511295f5a30332d5d03f0a6956bd9460 (this is just the latest master I have so there's a point of reference for the future), we can observe the behaviour of `make dist` in `lib/am/distdir.am`. Search for the `distdir-am` target within that file. You will see that if a file was already added to the distdir, it won't be added again.
Some of this file ordering may not be necessary anymore, we can investigate further and come back to this.
f2ba8ec to
1b91ade
Compare
I don't care about this very much, but will answer the question. Advantages of including bootstrapped files:
Disadvantages of including bootstrapped files:
|
Gitian builds
|
|
I personally prefer using Calling |
|
Noted, closing. Followups:
|
|
|
I also performed a gitian build, here's a diff of the source tarball and one produced with simply
git archive, as expected, the difference is only in the bootstrapped files.