8000 Avoid unnecessary translations by hebasto · Pull Request #297 · bitcoin-core/gui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Avoid unnecessary translations #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

Avoid unnecessary translations #297

merged 1 commit into from
May 25, 2021

Conversation

hebasto
Copy link
Member
@hebasto hebasto commented Apr 25, 2021

Working on translation, I found these translations introduced in #79, that are unnecessary (assuming the universal nature of the "BTC" string).

jarolrod
jarolrod reviewed Apr 25, 2021
View reviewed changes
Copy link
Member
@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 19d51a2

Tested that these are all the occurrences in this file, and cross-checked for any occurrences in other files. We already set the notr attribute in other areas of the code such as coincontroldialog.ui, overviewpage.ui, and sendcoinsdialog.ui.

Furthermore, BTC is treated as a symbol or unit of Bitcoin and is untranslatable by nature.

@Sjors
Copy link
Member
Sjors commented Apr 29, 2021

Concept ACK

@hebasto hebasto requested a review from laanwj May 8, 2021 07:09
promag
promag reviewed May 24, 2021
View reviewed changes
Copy link
Contributor
@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@hebasto hebasto merged commit 3ad1b88 into bitcoin-core:master May 25, 2021
@hebasto hebasto deleted the 210425-btc branch May 25, 2021 22:43
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 27, 2021
@hebasto
Merge bitcoin-core/gui#297: Avoid unnecessary translations
264fad0
@luke-jr
Copy link
Member
luke-jr commented Jun 12, 2021

Is it really untranslated? What about languages that don't use the Latin alphabet at all?

@hebasto
Copy link
Member Author
hebasto commented Jun 12, 2021

Is it really untranslated? What about languages that don't use the Latin alphabet at all?

For example? (not non-Latin languages, but abbreviated name "BTC" in non-Latin languages)

My three non-Latin languages use "BTC", btw.

@luke-jr
Copy link
Member
luke-jr commented Jun 12, 2021

I would expect Russian to use a Cyrillic abbreviation? Possibly Chinese and Japanese to get single-character units at some point?

@hebasto
Copy link
Member Author
hebasto commented Jun 12, 2021

I would expect Russian to use a Cyrillic abbreviation? Possibly Chinese and Japanese to get single-character units at some point?

I've made a quick re-check of some multi-language online services. All of them use "BTC" in non-Latin languages.

gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@apoelstra
Merge 3ad1b88 into merged_master (Bitcoin PR bitcoin-core/gui#297)
9933b7d
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@promag promag promag left review comments

@jarolrod jarolrod jarolrod left review comments

@laanwj laanwj Awaiting requested review from laanwj

Assignees
No one assigned
Labels
Translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hebasto @Sjors @luke-jr @promag @jarolrod
0