-
Notifications
You must be signed in to change notification settings - Fork 249
Rethinking Navigation #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethinking Navigation #1026
Conversation
No need to make a new PR, you can just keep force pushing on the same branch, GitHub will pick it up if you fixed the rebase. |
@mutatrum Damn, now I've already created a new PR. But I'll let you know next time, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only a few dumb questions.
main/http_server/axe-os/src/app/components/settings/settings.component.html
Show resolved
Hide resolved
main/http_server/axe-os/src/app/components/system/system.component.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-*
Discussed in #994
I opened this PR because #1017 had a wrong rebase. Sorry for that.
1. Reorder the app navigation
2. Extract sections into a single page