8000 Add release notes by duckAxe · Pull Request #1005 · bitaxeorg/ESP-Miner · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add release notes #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2025
Merged

Add release notes #1005

merged 1 commit into from
Jun 15, 2025

Conversation

duckAxe
Copy link
Contributor
@duckAxe duckAxe commented Jun 5, 2025 •
edited
Loading

This PR adds a link with release notes (modal with parsed markdown) to the update section so that the user is informed about the release changes.

The Release Notes link is grey colored because it is less important than the two .bin links.

Screen.Recording.2025-06-05.at.09.59.54.mov

@duckAxe duckAxe mentioned this pull request Jun 6, 2025
Merged
@duckAxe
Copy link
Contributor Author
duckAxe commented Jun 8, 2025

Blocked by #1014

@mutatrum mutatrum added the enhancement New feature or request label Jun 9, 2025
@mutatrum
Copy link
Collaborator

For the paranoid out there, one feature would be to have a setting to categorically disallow external calls. That, or have a modal confirmation popup the first time Axe-OS calls out to GitHub, maybe? Don't think it should be with this PR.

@duckAxe
< 8000 path d="M8 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM1.5 9a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Zm13 0a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z"> Copy link
Contributor Author
duckAxe commented Jun 12, 2025 •
edited
Loading

@mutatrum Paranoid people have already clicked the release check button. The link to the release notes will only appear after this step. If we want user confirmation for extern calls, then is the check button the right place. We can put the existing text "Clicking this button will connect to GitHub to check for the latest release, both files are required." in a modal and ask the user for confirmation. But it shouldn't be part of this PR.

@WantClue WantClue merged commit cda9c2d into bitaxeorg:master Jun 15, 2025
2 checks passed
duckAxe pushed a commit to duckAxe/ESP-Miner-Bitaxe that referenced this pull request Jun 16, 2025
FUP bitaxeorg#1005: Use new Modal Component for Release Notes
0396cfc
This was referenced Jun 16, 2025
Merged
Open
mutatrum pushed a commit that referenced this pull request Jun 19, 2025
@duckAxe
FUP #1005: Use Modal Component for Release Notes (#1041)
ecb0790 
* FUP #1005: Use new Modal Component for Release Notes

* Remove unused modal styling

* Solve merge conflicts

* Added comments to markdown regex

---------

Co-authored-by: duckAxe <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WantClue WantClue WantClue approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duckAxe @mutatrum @WantClue
0