Clean up duplicate ASIC reset code #986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutatrum
commented
May 30, 2025
Build was fine in vscode, not sure why it's failing on GitHub
mutatrum
commented
May 30, 2025
| @@ -20,12 +20,6 @@ | |||
| #define BM1366_CHIP_ID 0x1366 | |||
| #define BM1366_CHIP_ID_RESPONSE_LENGTH 11 | |||
|
|
|||
| #ifdef CONFIG_GPIO_ASIC_RESET | |||
There was a problem hiding this comment.
This probably never worked, CONFIG_GPIO_ASIC_RESET was undefined here.
mutatrum
commented
May 30, 2025
| @@ -102,6 +103,12 @@ void app_main(void) | |||
| queue_init(&GLOBAL_STATE.stratum_queue); | |||
| queue_init(&GLOBAL_STATE.ASIC_jobs_queue); | |||
|
|
|||
| if (asic_reset() != ESP_OK) { | |||
There was a problem hiding this comment.
Subtle change here, needs some testing. The asic is now reset before the serial port is initialised.
There was a problem hiding this comment.
Will do some testing on this
0xf0xx0
approved these changes
May 30, 2025
WantClue
approved these changes
Jun 9, 2025
duckAxe
pushed a commit
to duckAxe/ESP-Miner-Bitaxe
that referenced
this pull request
Jun 11, 2025
* Unify ASIC reset code * Add missing include Build was fine in vscode, not sure why it's failing on GitHub * Move asic_reset into separate file
Sign up for free
to join this conversation on GitHub.
699E
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the initialisation of the ASIC, it's reset. This code is the same for all models, and arguably doesn't belong in the ASIC module. Code is extracted into it's own class and re-used in main and self-test.