8000 api returns a JSON error for unhandled requests by 0xf0xx0 · Pull Request #972 · bitaxeorg/ESP-Miner · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

api returns a JSON error for unhandled requests #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

api returns a JSON error for unhandled requests #972

merged 1 commit into from
Jun 11, 2025

Conversation

0xf0xx0
Copy link
Contributor
@0xf0xx0 0xf0xx0 commented May 28, 2025

i noticed an unhandled api request redirects to the main page. this pr changes that to return a JSON object {"error":"unknown route"}.

@0xf0xx0 0xf0xx0 force-pushed the api-json-404 branch 2 times, most recently from de94492 to 5825a48 Compare May 28, 2025 19:16
@mutatrum mutatrum added the enhancement New feature or request label May 30, 2025
@mutatrum mutatrum added this to the 2.9.0 milestone Jun 4, 2025
WantClue
WantClue approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator
@WantClue WantClue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WantClue WantClue merged commit 40b7978 into bitaxeorg:master Jun 11, 2025
2 checks passed
@0xf0xx0 0xf0xx0 deleted the api-json-404 branch June 11, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutatrum mutatrum mutatrum approved these changes

@WantClue WantClue WantClue approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@0xf0xx0 @mutatrum @WantClue
0