8000 Fix inconsistent function naming @ edit.component.ts by duckAxe · Pull Request #969 · bitaxeorg/ESP-Miner · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix inconsistent function naming @ edit.component.ts #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Fix inconsistent function naming @ edit.component.ts #969

merged 1 commit into from
May 28, 2025

Conversation

duckAxe
Copy link
Contributor
@duckAxe duckAxe commented May 28, 2025

As @mutatrum correctly pointed out, the function names getDropdownFrequency and getCoreVoltage are inconsistent. I am aligning the function names with this request.

  • Renaming to getter functions dropdownFrequency and dropdownVoltage
  • Add return type Dropdown

@WantClue WantClue merged commit 63dc53d into bitaxeorg:dev-latest May 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutatrum mutatrum mutatrum approved these changes

@WantClue WantClue WantClue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duckAxe @mutatrum @WantClue
0