8000 Show restart warning only for relevant fields by duckAxe · Pull Request #967 · bitaxeorg/ESP-Miner · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Show restart warning only for relevant fields #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

duckAxe
Copy link
Contributor
@duckAxe duckAxe commented May 28, 2025

I have seen that the request has stalled. I think I have found a simple solution: working with a whitelist of fields.

By default, all fields trigger the restart warning. However, you can add single fields to the whitelist to prevent this. This method is simple and easy to maintain, even with newly added fields.

The restart warning is available on the following pages:

  • Network
    All fields trigger the restart warning.
  • Pool
    All fields trigger the restart warning.
  • Settings
    The following fields trigger the restart warning:
    -- display
    -- flipscreen
    -- invertscreen

Have I forgotten something? Please let me know.

Screen.Recording.2025-05-28.at.10.15.09.mov

Closes #581

@WantClue
Copy link
Collaborator

@duckAxe the displayTimeout should not trigger the restart warning

@duckAxe
Copy link
Contributor Author
duckAxe commented May 28, 2025

@duckAxe the displayTimeout should not trigger the restart warning

Easy. Just added to the whitelist. Fixed.

@WantClue WantClue added the design Design Enhancements label May 28, 2025
@WantClue WantClue merged commit f19afc1 into bitaxeorg:dev-latest May 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design Enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0