Ssd1309 extra screen #937
Merged
Ssd1309 extra screen #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main/screen.c
Outdated
| if (wifi_rssi_value_label) { | ||
| char rssi_buf[25]; | ||
|
|
||
| if (module->wifi_rssi < 0 && module->wifi_rssi >= -127) { // Typical RSSI range |
There was a problem hiding this comment.
ESP docs say it can actually sometimes be positive, for some reason?
| } | ||
| // If the candidate screen is SCR_WIFI_RSSI AND this is NOT a bigger display, | ||
| // then this screen should be skipped, and the loop will continue to find the next one. | ||
| } while (next_scr == SCR_WIFI_RSSI && GLOBAL_STATE->DISPLAY_CONFIG.v_res / 8 != 8); |
There was a problem hiding this comment.
We have to think about this a bit more. For now I would revert this bit, and just add the new screen for all displays. If we want to have different screen designs for different resolutions, it would make sense to do that in screen_start, only once.
There was a problem hiding this comment.
F.e. we could make 2 separate designs for the Wi-Fi, and either add one or the other on the SCR_WIFI_RSSI position. Or have a completely dynamic bit of the carousel, that a small screen has 4 screens (as an example), but a larger screen only has 3, with different designs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds ontop of #934
adds another screen depending on the resolution that's available to display wifi rssi.
To-Do: