10000 Fix swarm sorting by duckAxe · Pull Request #928 · bitaxeorg/ESP-Miner · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix swarm sorting #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

Conversation

duckAxe
Copy link
Contributor
@duckAxe duckAxe commented May 17, 2025

This PR solves the issue of lost sorting after manual and automatic swarm list refresh. Now the changed code remembers the user's sorting preference and applies them each time the swarm is updated. Even after (swarm) page reload.

Fixes #915

@jddebug
Copy link
jddebug commented May 17, 2025

It would be great if the swarm was numbered or at least if at the top it showed how many active miners are in the swarm. It's nice to be able to order them, but being able to at a glance know that all of your miners are still mining would be handy. Currently, I have to count them one by one and make sure they're all there.

@duckAxe
Copy link
Contributor Author
duckAxe commented May 17, 2025

@jddebug That's a nice idea, but it's not part of this fix / PR. Feel free to create an issue for it.

@mutatrum
Copy link
Collaborator

Thank you for the PR. #787 also addresses this, we need to see which is the best fit.

@mutatrum mutatrum linked an issue May 19, 2025 that may be closed by this pull request
@duckAxe
Copy link
Contributor Author
duckAxe commented May 19, 2025

Thank you for the PR. #787 also addresses this, we need to see which is the best fit.

With all due respect to @dustinb, I prefer my change because it retains the sorting even after a page reload. This way, I won't have to set my preferred sorting when I reopen the browser (tab).

@duckAxe
Copy link
Contributor Author
duckAxe commented May 19, 2025

@mutatrum Why hasn't the PR #787 already been merged? Because the review from @mrv777 is missing? I'm trying to figure out how the approval of pull requests works. Why are they not merged much faster if everything is right?

@mutatrum
Copy link
Collaborator
mutatrum commented May 20, 2025

@mutatrum Why hasn't the PR #787 already been merged? Because the review from @mrv777 is missing? I'm trying to figure out how the approval of pull requests works. Why are they not merged much faster if everything is right?

There's not much process. Currently it's @WantClue and me doing reviews, and occasionally others step in. There were a few more, but they're busy building other stuff or have less time due to personal stuff. You add a lot of PRs and it's good work, much appreciated. But we're simply limited in how much we can process, while we're also making new stuff. You're more than welcome into Discord, if you're not there yet, we would love to discuss it. That would be a better channel than here. https://discord.gg/osmu

8000

@duckAxe
Copy link
Contributor Author
duckAxe commented May 20, 2025

@mutatrum Thank you. I get it.

You're more than welcome into Discord, if you're not there yet, we would love to discuss it. That would be a better channel than here

I was banned from the osmu server because I posted an external link. Not my choice.

@benjamin-wilson
Copy link
Collaborator
benjamin-wilson commented May 20, 2025

duckAxe I was banned from the osmu server because I posted an external link. Not my choice.

If you give me your username I can review it. There is a bot that automatically bans new users from posting links are we are often attacked by spam.

Copy link
Collaborator
@mutatrum mutatrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WantClue WantClue added design Design Enhancements accepted This issue will be worked on labels May 21, 2025
Copy link
Collaborator
@WantClue WantClue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice one

@WantClue WantClue merged commit d419848 into bitaxeorg:dev-latest May 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted This issue will be worked on design Design Enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting on swarm page is not persisted
5 participants
0