-
Notifications
You must be signed in to change notification settings - Fork 249
Fix swarm sorting #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix swarm sorting #928
Conversation
It would be great if the swarm was numbered or at least if at the top it showed how many active miners are in the swarm. It's nice to be able to order them, but being able to at a glance know that all of your miners are still mining would be handy. Currently, I have to count them one by one and make sure they're all there. |
@jddebug That's a nice idea, but it's not part of this fix / PR. Feel free to create an issue for it. |
Thank you for the PR. #787 also addresses this, we need to see which is the best fit. |
There's not much process. Currently it's @WantClue and me doing reviews, and occasionally others step in. There were a few more, but they're busy building other stuff or have less time due to personal stuff. You add a lot of PRs and it's good work, much appreciated. But we're simply limited in how much we can process, while we're also making new stuff. You're more than welcome into Discord, if you're not there yet, we would love to discuss it. That would be a better channel than here. https://discord.gg/osmu |
@mutatrum Thank you. I get it.
I was banned from the osmu server because I posted an external link. Not my choice. |
If you give me your username I can review it. There is a bot that automatically bans new users from posting links are we are often attacked by spam. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice one
This PR solves the issue of lost sorting after manual and automatic swarm list refresh. Now the changed code remembers the user's sorting preference and applies them each time the swarm is updated. Even after (swarm) page reload.
Fixes #915