Move restart warning to Toast #926
Conversation
main/http_server/axe-os/src/app/components/edit/edit.component.html
Outdated
Show resolved
Hide resolved
|
Merges, created #944 for possible follow-up. |
|
You introduced a misbehavior with this PR, the "you must restart your device for changes to take effect" is now being shown every single time. Which is incorrect. This is only needed on certain changes and not always @duckAxe would be nice if you can tackle this? |
|
@WantClue Have you tested my changes? The message only pops up when you save something and only on the pages I mentioned. Check also my code changes on .ts files. There is always a condition around the message. |
@duckAxe Yes I've tested them, the provided vid e.g. shows the toast on the freq change as an example. Which does change on the fly and doesn't req a reboot 2025-05-25.15-14-29.mp4 |
|
@WantClue The behavior shown in the video is expected. In both cases, restarting the device after saving is suggested. I see no difference in the way the user is communicated with. Before my PR |
|
@WantClue Do you mean something else? Are you saying that a restart isn't required for every field change? Do I understand correctly? If so, that wasn't the case before I made the change. The message "You must restart ..." was always visible, making it clear to the user that a restart was necessary for every adjustment. If we want to show the message only for certain settings, we can do so in a new PR. In order to do so, I need to know which settings require a restart and which do not. |
|
That would be #741, which is still open. |
Exactly. |
The hint
You must restart this device after saving for changes to take effectis currently right next to the save button. That does not look good. It would be much better if this warning only appeared when needed. For example, when saving.My idea is to display the warning as a Toast notification. This way, the user would immediately notice the warning when saving.
This affects 3 settings pages: Pool, Network, (Miner) Settings.
Before
After
