8000 Statistics task for previous chart data by terratec · Pull Request #898 · bitaxeorg/ESP-Miner · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Statistics task for previous chart data #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 21, 2025
Merged

Statistics task for previous chart data #898

merged 9 commits into from
May 21, 2025

Conversation

terratec
Copy link
Contributor
@terratec terratec commented May 5, 2025

with new API endpoint for statistics.
The configuration with 0 data points is live data only (old behavior) with statistics disabled.
The poll rate is automatically set based on the configured duration.

@mutatrum
Copy link
Collaborator
mutatrum commented May 7, 2025

My sincere apologies, we had to re-do the history of dev-latest. Can you apply your commits to the top of current dev-latest?

@terratec terratec force-pushed the statistics_task branch from 56701dd to 6603cdc Compare May 7, 2025 18:34
mutatrum
mutatrum reviewed May 7, 2025
View reviewed changes
main/http_server/axe-os/src/app/components/home/home.component.ts
public previousDataLabel: number[] = [];
public previousHashrateData: number[] = [];
public previousTemperatureData: number[] = [];
public previousPowerData: number[] = [];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it feasible to use the existing arrays for this, instead of having 4 new ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my first approach but sometimes the chart was distorted. It seems the previous and new data arrives asynchronous.
Is it possible to synchronize the observable subscriptions?

@mutatrum
Copy link
Collaborator
mutatrum commented May 7, 2025

Thanks for the rebase, hope it wasn't too bad. Did a code level review, with one comment. I have a feeling it can be simplified, by re-using the existing storage, but not 100% sure. I haven't tested the code yet.

@terratec
Copy link
Contributor Author
terratec commented May 7, 2025

Thanks for the rebase, hope it wasn't too bad. Did a code level review, with one comment. I have a feeling it can be simplified, by re-using the existing storage, but not 100% sure. I haven't tested the code yet.

No the rebase was successful :)

@WantClue WantClue self-assigned this May 16, 2025
@WantClue WantClue added enhancement New feature or request design Design Enhancements labels May 16, 2025
@WantClue WantClue added this to the 2.8.0 milestone May 16, 2025
@WantClue
Copy link
Collaborator

LGTM

duckAxe
duckAxe suggested changes May 20, 2025
View reviewed changes
@WantClue WantClue merged commit d2fa93b into bitaxeorg:dev-latest May 21, 2025
2 checks passed
duckAxe pushed a commit to duckAxe/ESP-Miner-Bitaxe that referenced this pull request May 21, 2025
FUP bitaxeorg#898: Fix styling for statistics settings
fb3dc37
@duckAxe duckAxe mentioned this pull request May 21, 2025
Merged
@terratec terratec deleted the statistics_task branch May 22, 2025 17:08
mutatrum pushed a commit that referenced this pull request May 29, 2025
@duckAxe
FUP #898: Fix styling for statistics settings (#940)
f6c9276 
* FUP #898: Fix styling for statistics settings

* Positioning the sliders under each other

---------

Co-authored-by: duckAxe <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutatrum mutatrum mutatrum left review comments

@duckAxe duckAxe duckAxe requested changes

@WantClue WantClue WantClue approved these changes

Assignees

@WantClue WantClue

Labels
design Design Enhancements enhancement New feature or request
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@terratec @mutatrum @WantClue @duckAxe
0