fix: remove polarity bit #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skot
approved these changes
Apr 16, 2025
adammwest
pushed a commit
to adammwest/ESP-Miner
that referenced
this pull request
Apr 18, 2025
WantClue
added a commit
that referenced
this pull request
May 2, 2025
un-painted
pushed a commit
to un-painted-org/ESP-Miner
that referenced
this pull request
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polarity bit was never set correct before, it never worked. The UI button in this case was useless.
This PR removes the entire polarity bit code, keeps the last necessary comments if we decide to reintroduce it back again in emc2101.c
this closes #844
// --- Configure Fan Settings (Register 0x4A) ---
// Start with a base configuration:
// Bit 7 (MASK) = 0: Tach Alert Enabled
// Bit 6 (EN) = 1: *** FAN DRIVER ENABLED ***
// Bit 5 (LEVEL)= 1: Direct Setting Mode (use PWM Duty Cycle Reg 0x4C)
// Bit 4 (POL) = 0: Normal Polarity (placeholder, set below)
// Bit 3:2(EDGES)=00: 2 Tach pulses per revolution (standard)
// Bit 1:0(RANGE)=00: PWM Frequency ~22.5 kHz (common setting)