8000 New prefix: hissta by nalikapalayoor · Pull Request #1560 · biopragmatics/bioregistry · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

New prefix: hissta #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 19, 2025
Merged

New prefix: hissta #1560

merged 4 commits into from
May 19, 2025

Conversation

nalikapalayoor
Copy link
Contributor

This PR curates a new prefix hissta. This database contains information about tissue samples from various tissues using different sampling techniques.

Pubmed: https://pubmed.ncbi.nlm.nih.gov/40163697/
Website: https://kbds.re.kr/hissta/

@bgyori
Copy link
Contributor
bgyori commented May 5, 2025

This looks good but there is an issue with how identifiers are defined: the number used in the URL pattern, which is interpreted as a "sample index" is not the same as the "Sample ID" that is listed under the given record. For instance, the "sample index" is 72 in the example below but the"Sample ID" is XEN046. I couldn't find a way to resolve the Sample IDs

image

@nalikapalayoor
Copy link
Contributor Author

This looks good but there is an issue with how identifiers are defined: the number used in the URL pattern, which is interpreted as a "sample index" is not the same as the "Sample ID" that is listed under the given record. For instance, the "sample index" is 72 in the example below but the"Sample ID" is XEN046. I couldn't find a way to resolve the Sample IDs

I didn't notice that, do you recomend we curate this as "unclear" instead and write a small comment about this? I agree I don't see a good way to resolve the sample IDs either.

@bgyori
Copy link
Contributor
bgyori commented May 13, 2025

This looks good but there is an issue with how identifiers are defined: the number used in the URL pattern, which is interpreted as a "sample index" is not the same as the "Sample ID" that is listed under the given record. For instance, the "sample index" is 72 in the example below but the"Sample ID" is XEN046. I couldn't find a way to resolve the Sample IDs

I didn't notice that, do you recomend we curate this as "unclear" instead and write a small comment about this? I agree I don't see a good way to resolve the sample IDs either.

Yes, let's do that

@codecov Codecov
Copy link
codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.16%. Comparing base (8950e70) to head (853c83f).
Report is 476 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1560      +/-   ##
==========================================
+ Coverage   42.51%   47.16%   +4.64%     
==========================================
  Files         117      122       +5     
  Lines        8327     8876     +549     
  Branches     1963     1495     -468     
==========================================
+ Hits         3540     4186     +646     
+ Misses       4582     4434     -148     
- Partials      205      256      +51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bgyori bgyori merged commit 6d1a76b into biopragmatics:main May 19, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalikapalayoor @bgyori
0