[ENH] Lemmagen - Use ISO language codes #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
f2fb09f to
6ee6269
Compare
|
I get the following error message when I open a saved workflow. I'm attaching the workflow (I reset settings before creating it): |
|
@VesnaT, the problem here is that I didn't increase the settings version. Since I increased it in #1024, and it has not been released yet, I think it may not be necessary. What do you think? Increasing the settings version would complicate the implementation of the migrations. If you are okay with not changing the settings version, you can make te workflow with tag 1.15.0 (git checkout 1.15.0) and open it with this change. It should work. |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR is part of #963, which I am splitting into smaller pieces for easier review.
The main motivation behind this is to make Preprocess work with language from Corpus.
Description of changes
This PR prepare a Lemmagen normalizer to communicate (get and return languages) as ISO codes, which is necessary to enable language from Corpus (languages are stored in Corpus in ISO format).
After I changed Lemmagen to work with ISO language codes, I also had to adapt the Preprocess Widget to store settings as ISO codes and call the Lemmagen filter with ISO language code.
Udpipe and Snowball will be implemented in separate PRs.
Includes