10000 feat: search for `biome` in PATH by nhedger · Pull Request #129 · biomejs/biome-vscode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: search for biome in PATH #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 13, 2024
Merged

feat: search for biome in PATH #129

merged 5 commits into from
Feb 13, 2024

Conversation

nhedger
Copy link
Member
@nhedger nhedger commented Feb 11, 2024

This PR introduces a new feature to allow searching for the biome binary in the PATH.

Here's where it comes in the current detection order.

  1. Search in DEBUG_SERVER_PATH
  2. Look in biome.lspBin
  3. Look in project's dependencies
  4. Search in PATH
  5. Download global binary

Tests

  • macOS
  • Linux
  • Windows

Possible fix for #127

@nhedger nhedger linked an issue Feb 11, 2024 that may be closed by this pull request
@nhedger nhedger marked this pull request as ready for review February 13, 2024 08:16
@nhedger nhedger merged commit eeb6499 into main Feb 13, 2024
@nhedger nhedger deleted the feat/search-in-path branch February 13, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 NixOS support
3 participants
0